From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328AbcBIMl4 (ORCPT ); Tue, 9 Feb 2016 07:41:56 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41692 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645AbcBIMlx (ORCPT ); Tue, 9 Feb 2016 07:41:53 -0500 Date: Tue, 9 Feb 2016 12:41:33 +0000 From: Mark Brown To: John Crispin Cc: Liam Girdwood , Matthias Brugger , chen.zhong@mediatek.com, HenryC.Chen@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Message-ID: <20160209124133.GE13270@sirena.org.uk> References: <1454874037-38905-1-git-send-email-blogic@openwrt.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz" Content-Disposition: inline In-Reply-To: <1454874037-38905-1-git-send-email-blogic@openwrt.org> X-Cookie: Nothing happens. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V5 1/2] regulator: Add document for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --brEuL7wsLY8+TuWz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Feb 07, 2016 at 08:40:36PM +0100, John Crispin wrote: > +Required properties: > +- compatible: "mediatek,mt6323-regulator" I'm really not happy with MFD subfunctions like this which add no information over the parent device name appearing directly in the binding, it results in us putting Linux specifics about how we split the device up into the driver. It's not like this could realistically be used separately to the parent device. Just have the MFD create the device directly or if the individual regulators are reusable IPs which can share a driver then describe them as such in the DT. --brEuL7wsLY8+TuWz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWud58AAoJECTWi3JdVIfQPf0H/jEkIXIvvJDcvu9AQclWFyDn ft5K80u4zn4Hb6bfZ2mfAKtzAPQnBnloXHrkzuy+vfUBhX1iMNLBtJhGmFmuNQRx 37MYAN5ZRNULlLiMK9a7f0l6JLJjjFntoBr695EOqabIK/Itw02Sbo5UAiUHjTvI 3uL4Ri55W6k33AhhAROwh2eRXtvdbTi0p/9oQQj8+rvaualF/DOm/5PhPgURzu2+ kzK7Oh4Rsdmvil8v84xXawRHeThWo4J0M2owKKQrbJBuOCmHdaxTElhZn8GeGK5Q Y0PzgInGdh5TtDMRD5wOIoEcSjpOS1GGhWT/FwF+Xnn1cWgr1YVugvAGpfbMRvk= =Mgy3 -----END PGP SIGNATURE----- --brEuL7wsLY8+TuWz--