mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Andy Lutomirski <luto@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Alexander Popov <alpopov@ptsecurity.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/head64: use pointer type in sizeof
Date: Tue, 9 Feb 2016 14:53:44 +0100	[thread overview]
Message-ID: <20160209135344.GA26641@gmail.com> (raw)
In-Reply-To: <1455025494-4063-1-git-send-email-kuleshovmail@gmail.com>


* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> We changed loops with memset in the 5e9ebbd87a99 commit (x86/boot:
> Micro-optimize reset_early_page_tables()). The base for size of
> memset was size of pud_p/pmd_p, but the they are actually
> represented as pointers, although they have the same sizes.

That's rather confused. Also the title is confused:

  x86/head64: use pointer type in sizeof

what the fix does it to _not_ use a pointer type.

I fixed the title and the changelog, but you really need to be more careful...

Thanks,

	Ingo

  reply	other threads:[~2016-02-09 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 13:44 Alexander Kuleshov
2016-02-09 13:53 ` Ingo Molnar [this message]
2016-02-09 16:09 ` [tip:x86/boot] x86/boot: Use proper array element type in memset( ) size calculation tip-bot for Alexander Kuleshov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209135344.GA26641@gmail.com \
    --to=mingo@kernel.org \
    --cc=alpopov@ptsecurity.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome