From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756858AbcBINyf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 08:54:35 -0500
Received: from mail-wm0-f49.google.com ([74.125.82.49]:32896 "EHLO
	mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754974AbcBINyd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 08:54:33 -0500
Date: Tue, 9 Feb 2016 14:54:55 +0100
From: Daniel Vetter <daniel@ffwll.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>,
        Alexandre Courbot <gnurou@gmail.com>,
        Terje =?iso-8859-1?Q?Bergstr=F6m?= <tbergstrom@nvidia.com>,
        Daniel Stone <daniels@collabora.com>,
        Stephen Warren <swarren@wwwdotorg.org>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Thierry Reding <treding@nvidia.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/tegra: remove unused variable
Message-ID: <20160209135455.GW11240@phenom.ffwll.local>
Mail-Followup-To: Arnd Bergmann <arnd@arndb.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>,
	Alexandre Courbot <gnurou@gmail.com>,
	Terje =?iso-8859-1?Q?Bergstr=F6m?= <tbergstrom@nvidia.com>,
	Daniel Stone <daniels@collabora.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Thierry Reding <treding@nvidia.com>,
	linux-arm-kernel@lists.infradead.org
References: <1455020923-1089878-1-git-send-email-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1455020923-1089878-1-git-send-email-arnd@arndb.de>
X-Operating-System: Linux phenom 4.3.0-1-amd64 
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 09, 2016 at 01:28:15PM +0100, Arnd Bergmann wrote:
> A newly merged patch removed the only user of this variable,
> leading to a harmless gcc warning:
> 
> drivers/gpu/drm/tegra/drm.c: In function 'tegra_drm_preclose':
> drivers/gpu/drm/tegra/drm.c:861:19: error: unused variable 'crtc' [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Cc: Terje Bergström <tbergstrom@nvidia.com>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Fixes: 0417d424ac0d ("drm/tegra: Stop cancelling page flip events")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Already fixed by Dave in 10c1b6183a163aca59ba92b88f2b4c4cecd20d4c. Thanks
anyway for the quick patch.
-Daniel

> ---
>  drivers/gpu/drm/tegra/drm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
> index 021d0e1398fb..8e6b18caa706 100644
> --- a/drivers/gpu/drm/tegra/drm.c
> +++ b/drivers/gpu/drm/tegra/drm.c
> @@ -858,7 +858,6 @@ static void tegra_drm_preclose(struct drm_device *drm, struct drm_file *file)
>  {
>  	struct tegra_drm_file *fpriv = file->driver_priv;
>  	struct tegra_drm_context *context, *tmp;
> -	struct drm_crtc *crtc;
>  
>  	list_for_each_entry_safe(context, tmp, &fpriv->contexts, list)
>  		tegra_drm_context_free(context);
> -- 
> 2.7.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch