From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756781AbcBIQun (ORCPT ); Tue, 9 Feb 2016 11:50:43 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:57129 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756483AbcBIQuk (ORCPT ); Tue, 9 Feb 2016 11:50:40 -0500 Date: Tue, 9 Feb 2016 08:50:27 -0800 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Matthew Garrett , Pali =?iso-8859-1?Q?Roh=E1r?= , Richard Purdie , Jacek Anaszewski , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request() Message-ID: <20160209165027.GA1309@dvhart-mobl5.amr.corp.intel.com> References: <1453472848-3118-1-git-send-email-kernel@kempniu.pl> <1453472848-3118-8-git-send-email-kernel@kempniu.pl> <20160208184456.GM1779@malice.jf.intel.com> <20160209132736.GA7443@eudyptula.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160209132736.GA7443@eudyptula.hq.kempniu.pl> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2016 at 02:27:36PM +0100, Michał Kępień wrote: > > > An SMBIOS buffer pointer does not need to be returned by > > > dell_smbios_send_request(), because SMBIOS call results are stored in > > > the buffer passed as input. > > > > This should come before 6/16, update the commit message to reflect the module > > exported buffer (not the one passed as input), or possibly just merge this patch > > and 6/16 as correcting the use of SMBIOS buffer within the module. > > I have only now noticed that I phrased the commit message for this patch > rather unfortunately as it inappropriately conveyed my reasoning. What > I meant by "the buffer passed as input" was not "the buffer passed as an > argument to dell_smbios_send_request()", but rather "the buffer passed > to the SMI handler". In other words, there is no reason to return a > buffer from dell_smbios_send_request(), because each caller will simply > find their output in the same buffer they used to provide input (no > matter whether the latter is passed as a function argument or accessed > using a module-wide variable). > > Anyway, as even the above explanation is hardly a stellar demonstration > of clarity, I believe your idea of resolving this issue may simply be > the best one, thanks. In my tree, I reworded this as: dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request() An SMBIOS buffer pointer does not need to be returned by dell_smbios_send_request(), because SMBIOS call results are stored in the buffer exported by the module. Is that acceptable? -- Darren Hart Intel Open Source Technology Center