From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756641AbcBISK7 (ORCPT ); Tue, 9 Feb 2016 13:10:59 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:42557 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbcBISK5 (ORCPT ); Tue, 9 Feb 2016 13:10:57 -0500 Date: Tue, 9 Feb 2016 12:10:31 -0600 From: Nishanth Menon To: Jassi Brar CC: Devicetree List , Franklin S Cooper Jr , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Santosh Shilimkar Subject: Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager Message-ID: <20160209181031.GA23603@kahuna> References: <1454690044-2560-1-git-send-email-nm@ti.com> <1454690044-2560-2-git-send-email-nm@ti.com> <56B9DC30.5040806@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09:43-20160209, Nishanth Menon wrote: > On Tue, Feb 9, 2016 at 8:54 AM, Jassi Brar wrote: [..] > Let me prototype this as part of of_xlate and see if I can pull the > qinst data back out.. obviously one negative will be that I will > register *all* valid channels as part of probe.. at least based on > initial code i wrote today morning.. OK - I believe I have it working now. How does the following look? If this looks fine to you, then I will post a v2 including the driver update. Changes here: - dropped the generic message-manager compatible - dropped child nodes - moved the valid queue information to driver (no longer in dts) - rx interrupts per SoC are explicitly named list in binding(and dts) Texas Instruments' Message Manager Driver ======================================== The Texas Instruments' Message Manager is a mailbox controller that has configurable queues selectable at SoC(System on Chip) integration. The Message manager is broken up into queues in different address regions that are called "proxies" - each instance is unidirectional and is instantiated at SoC integration level to indicate receive or transmit path. Message Manager Device Node: =========================== Required properties: -------------------- - compatible: Shall be: "ti,k2g-message-manager" - reg-names queue_proxy_region - Map the queue proxy region. queue_state_debug_region - Map the queue state debug region. - reg: Contains the register map per reg-names. - #mbox-cells Shall be 2. Contains the queue ID and proxy ID in that order referring to the transfer path. - interrupt-names: Contains interrupt names matching the rx transfer path for a given SoC. Receive interrupts shall be of the format: "rx__". For ti,k2g-message-manager, this shall contain: "rx_005_002", "rx_057_002" - interrupts: Contains the interrupt information corresponding to interrupt-names property. Example(K2G): ------------ msgmgr: msgmgr@02a00000 { compatible = "ti,k2g-message-manager"; #mbox-cells = <2>; reg-names = "queue_proxy_region", "queue_state_debug_region"; reg = <0x02a00000 0x400000>, <0x028c3400 0x400>; interrupt-names = "rx_005_002", "rx_057_002"; interrupts = , ; }; pmmc: pmmc { [...] mbox-names = "rx", "tx"; # RX queue ID is 5, proxy ID is 2 # TX queue ID is 0, proxy ID is 0 mboxes= <&msgmgr 5 2>, <&msgmgr 0 0>; [...] }; -- Regards, Nishanth Menon