From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbcBIThB (ORCPT ); Tue, 9 Feb 2016 14:37:01 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42702 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbcBITg6 (ORCPT ); Tue, 9 Feb 2016 14:36:58 -0500 Date: Tue, 9 Feb 2016 19:36:16 +0000 From: Mark Brown To: Vignesh R Cc: Tony Lindgren , Brian Norris , Rob Herring , Russell King , hramrach@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Message-ID: <20160209193616.GN13270@sirena.org.uk> References: <1449807000-6457-1-git-send-email-vigneshr@ti.com> <1449807000-6457-4-git-send-email-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ie5iOtK4e9kgqh2F" Content-Disposition: inline In-Reply-To: <1449807000-6457-4-git-send-email-vigneshr@ti.com> X-Cookie: Nothing happens. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ie5iOtK4e9kgqh2F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 11, 2015 at 09:39:58AM +0530, Vignesh R wrote: > + if (spi_flash_read_supported(spi)) { > + struct spi_flash_read_message msg; > + int ret; > + > + msg.buf = buf; > + msg.from = from; > + msg.len = len; > + msg.read_opcode = nor->read_opcode; > + msg.addr_width = nor->addr_width; > + msg.dummy_bytes = dummy; > + /* TODO: Support other combinations */ > + msg.opcode_nbits = SPI_NBITS_SINGLE; > + msg.addr_nbits = SPI_NBITS_SINGLE; > + msg.data_nbits = m25p80_rx_nbits(nor); > + > + ret = spi_flash_read(spi, &msg); > + *retlen = msg.retlen; > + return ret; Looking at this I can't help but think that spi_flash_read() ought to have the stub in rather than the caller. But given that we're pretty much only ever expecting one user I'm not 100% sure it actually matters. Anyway, I applied the first two patches. --Ie5iOtK4e9kgqh2F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWuj+wAAoJECTWi3JdVIfQ1X8H/2RT2Qyt7866DsiogZkzSEDL KBGCrfAapFj8N21nCesp/ap88F+iCqSCyRB8W8xAtNEawl23/71tY8G5aEqfJbCW FWnJrddQk1wdJj93uxbZFIdj1Dgqn1savkFr+nuTVjLCLdPYlJWK+G4a2ZkSXdj5 qMJDvlPDUJgO6P7OYIh/DETPtwcPVVTe9DPMboZBetGLiVXfgBrWwHhyddkt3VTb OmqoZ4W9m2AUwbZ5PVv1EWOzZlAXGh6vhNS57LlGAA/OcoQGEZKzq8Qmjp+G1whg A4KmvHz8xzZJnv6hiDETBWWqivrRCUltZGB4k6HphFR2CJdhLMopj7+E1xHY0lY= =DJI7 -----END PGP SIGNATURE----- --Ie5iOtK4e9kgqh2F--