From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757053AbcBJJBX (ORCPT ); Wed, 10 Feb 2016 04:01:23 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:54136 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932219AbcBJJBT (ORCPT ); Wed, 10 Feb 2016 04:01:19 -0500 Date: Wed, 10 Feb 2016 10:01:06 +0100 From: Ralf Baechle To: John Crispin Cc: weiyj_lk@163.com, Matthias Brugger , linux-mips@linux-mips.org, Wei Yongjun , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe() Message-ID: <20160210090106.GA10352@linux-mips.org> References: <1454768659-32720-1-git-send-email-weiyj_lk@163.com> <56B613D3.2070709@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B613D3.2070709@openwrt.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 06, 2016 at 04:40:03PM +0100, John Crispin wrote: > On 06/02/2016 15:24, weiyj_lk@163.com wrote: > > From: Wei Yongjun > > > > In case of error, the function devm_ioremap_resource() returns > > ERR_PTR() and never returns NULL. The NULL test in the return > > value check should be replaced with IS_ERR(). > > > > Signed-off-by: Wei Yongjun > > Hi, > > thanks for the fix. > > Acked-by: John Crispin > > @Ralf: can you merge this via LMO with the next PR please ? > > @mbgg: ignore the patch please it is for the legacy MIPS SoCs Applied. Thanks folks, Ralf