From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbcBJOhM (ORCPT ); Wed, 10 Feb 2016 09:37:12 -0500 Received: from smtprelay0200.hostedemail.com ([216.40.44.200]:40442 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751887AbcBJOhH (ORCPT ); Wed, 10 Feb 2016 09:37:07 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:69:355:379:541:599:800:857:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2282:2393:2553:2559:2562:2895:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4184:4321:4560:5007:6119:6261:7576:7875:7901:7903:7974:8660:9010:9108:9163:9545:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13142:13148:13230:14659:21060:21063:21080:21325:30029:30054:30055:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: teeth97_36bef65c5203 X-Filterd-Recvd-Size: 4352 Date: Wed, 10 Feb 2016 09:37:02 -0500 From: Steven Rostedt To: Juri Lelli Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, luca.abeni@unitn.it, vincent.guittot@linaro.org, wanpeng.li@hotmail.com Subject: Re: [PATCH 1/2] sched/deadline: add per rq tracking of admitted bandwidth Message-ID: <20160210093702.10c655be@gandalf.local.home> In-Reply-To: <20160210113258.GX11415@e106622-lin> References: <1454935531-7541-1-git-send-email-juri.lelli@arm.com> <1454935531-7541-2-git-send-email-juri.lelli@arm.com> <20160210113258.GX11415@e106622-lin> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2016 11:32:58 +0000 Juri Lelli wrote: > Hi, > > I've updated this patch since, with a bit more testing and talking with > Luca in private, I realized that the previous version didn't manage > switching back and forth from SCHED_DEADLINE correctly. Thanks a lot > Luca for your feedback (even if not visible on the list). > > I updated the testing branch accordingly and added a test to my tests > that stresses switch-in/switch-out. > > I don't particularly like the fact that we break the scheduling classes > abstraction in __dl_overflow(), so I think a little bit of refactoring > is still needed. But that can also happen afterwards, if we fix the > problem with root domains. > > Best, > > - Juri > > --->8--- > > >From 62f70ca3051672dce209e8355cf5eddc9d825c2a Mon Sep 17 00:00:00 2001 > From: Juri Lelli > Date: Sat, 6 Feb 2016 12:41:09 +0000 > Subject: [PATCH 1/2] sched/deadline: add per rq tracking of admitted bandwidth > I applied this patch and patch 2 and hit this: [ 2298.134284] ------------[ cut here ]------------ [ 2298.138933] WARNING: CPU: 4 PID: 0 at /home/rostedt/work/git/linux-trace.git/kernel/sched/sched.h:735 task_dead_dl+0xc5/0xd0() [ 2298.150350] Modules linked in: ip6table_filter ip6_tables ebtable_nat ebtables xt_CHECKSUM iptable_mangle bridge stp llc bluetooth lockd grace snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core x86_pkg_temp_thermal snd_seq vhost_net snd_seq_device tun vhost macvtap macvlan coretemp iTCO_wdt snd_pcm hp_wmi rfkill kvm_intel sparse_keymap iTCO_vendor_support snd_timer snd acpi_cpufreq kvm i2c_i801 mei_me mei soundcore lpc_ich mfd_core irqbypass wmi serio_raw uinput i915 i2c_algo_bit e1000e drm_kms_helper crc32_pclmul ptp crc32c_intel drm pps_core i2c_core video sunrpc [ 2298.207495] CPU: 4 PID: 0 Comm: swapper/4 Not tainted 4.5.0-rc1-test+ #204 [ 2298.214392] Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v02.05 05/07/2012 [ 2298.223371] ffffffff81abc680 ffff880119433d68 ffffffff81411c3f 0000000000000000 [ 2298.230904] ffffffff81abc680 ffff880119433da0 ffffffff810acf66 ffff88011eb16f40 [ 2298.238435] ffff88001ee16200 ffffffff81fd4a00 00000000000aaaaa 0000000000000001 [ 2298.245958] Call Trace: [ 2298.248431] [] dump_stack+0x50/0xb1 [ 2298.253597] [] warn_slowpath_common+0x86/0xc0 [ 2298.259627] [] warn_slowpath_null+0x1a/0x20 [ 2298.265490] [] task_dead_dl+0xc5/0xd0 [ 2298.270828] [] finish_task_switch+0x16f/0x310 [ 2298.276871] [] ? pick_next_task_dl+0xb3/0x250 [ 2298.282906] [] __schedule+0x3d3/0x9e0 [ 2298.288252] [] schedule+0x41/0xc0 [ 2298.293242] [] schedule_preempt_disabled+0x18/0x30 [ 2298.299712] [] cpu_startup_entry+0x74/0x4e0 [ 2298.305573] [] start_secondary+0x2bf/0x330 [ 2298.311347] ---[ end trace 732d16efabe456f1 ]--- It's the warning you added in __dl_sub_ac(). Things appear to still get all screwed up with cpusets and root domains, but I can still recover with playing with load_balance. -- Steve