From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149AbcBJKiT (ORCPT ); Wed, 10 Feb 2016 05:38:19 -0500 Received: from foss.arm.com ([217.140.101.70]:46084 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbcBJKiS (ORCPT ); Wed, 10 Feb 2016 05:38:18 -0500 Date: Wed, 10 Feb 2016 10:38:14 +0000 From: Catalin Marinas To: Laura Abbott Cc: Will Deacon , Mark Rutland , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv4 2/3] arm64: Add support for ARCH_SUPPORTS_DEBUG_PAGEALLOC Message-ID: <20160210103814.GC13577@e104818-lin.cambridge.arm.com> References: <1454718288-31374-1-git-send-email-labbott@fedoraproject.org> <1454718288-31374-3-git-send-email-labbott@fedoraproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454718288-31374-3-git-send-email-labbott@fedoraproject.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 04:24:47PM -0800, Laura Abbott wrote: > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -149,6 +149,19 @@ static void split_pud(pud_t *old_pud, pmd_t *pmd) > } while (pmd++, i++, i < PTRS_PER_PMD); > } > > +bool block_mappings_allowed(phys_addr_t (*pgtable_alloc)(void)) > +{ > + > + /* > + * If debug_page_alloc is enabled we must map the linear map > + * using pages. However, other mappings created by > + * create_mapping_noalloc must use sections in some cases. Allow > + * sections to be used in those cases, where no pgtable_alloc > + * function is provided. > + */ > + return !pgtable_alloc || !debug_pagealloc_enabled(); > +} This breaks the build when CONFIG_DEBUG_PAGEALLOC is not enabled (defconfig) since debug_pagealloc_enabled() is not defined. A fix went in next/master as commit 0987684b855c ("mm-slab-clean-up-debug_pagealloc-processing-code-fix"). I need to track it down and merge it via the arm64 tree, otherwise I'll add some #ifdefs in this function. BTW, shouldn't the block_mappings_allowed() function be static? -- Catalin