From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbcBJQ6h (ORCPT ); Wed, 10 Feb 2016 11:58:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:36568 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbcBJQ6f (ORCPT ); Wed, 10 Feb 2016 11:58:35 -0500 Date: Wed, 10 Feb 2016 17:58:33 +0100 From: Petr Mladek To: Sergey Senozhatsky Cc: Andrew Morton , Jan Kara , Tejun Heo , Kyle McMartin , Dave Jones , Calvin Owens , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again Message-ID: <20160210165833.GH12548@pathway.suse.cz> References: <1453536913-9545-1-git-send-email-sergey.senozhatsky@gmail.com> <1453536913-9545-3-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453536913-9545-3-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote: > Every jump to `again' label will call console_cont_flush(), > which is not really something big -- it just adds one extra > raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to > keep the previous behaviour we can call console_cont_flush() > only when `retry' is false -- which happens once, all jumps > to `again' label have `retry' set to true. The patch is correct and restores the original behavior, so Reviewed-by: Petr Mladek But I would personally omit it. We see the cont buffer earlier without this patch. Best Regards, Petr PS: I will review the other patches tomorrow.