From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752719AbcBKBZi (ORCPT ); Wed, 10 Feb 2016 20:25:38 -0500 Received: from tex.lwn.net ([70.33.254.29]:38726 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbcBKBZg (ORCPT ); Wed, 10 Feb 2016 20:25:36 -0500 Date: Wed, 10 Feb 2016 18:25:35 -0700 From: Jonathan Corbet To: Justin Keller Cc: linux-kernel@vger.kernel.org, isdn@linux-pingi.de, netdev@vger.kernel.org Subject: Re: possible patch Message-ID: <20160210182535.5d46bbca@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2016 19:49:11 -0500 Justin Keller wrote: > I am new to submitting patches, so sorry if I am doing it wrong. My idea was > to change line 147 in drivers/isdn/pcbit/callbacks.c from > if (cbdata->data.setup.CallingPN == NULL) { > > to > > if (cbdata->data.setup.CallingPN == NULL || > sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) { If you want to patch the kernel, the best way to describe what you want to do is to ... send a patch. Before you do so, though: - Please read the available documentation, including SubmittingPatches and development-process/* - Prepare a proper changelog saying *why* you want to make this change. You are trying to change the ISDN subsystem, which is pretty static these days; what current problem are you running into that makes you think this change needs to be applied to the kernel? Thanks, jon