From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbcBKAnc (ORCPT ); Wed, 10 Feb 2016 19:43:32 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33327 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbcBKAna convert rfc822-to-8bit (ORCPT ); Wed, 10 Feb 2016 19:43:30 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Michael Turquette In-Reply-To: <1453127331-20616-3-git-send-email-lee.jones@linaro.org> Cc: kernel@stlinux.com, maxime.coquelin@st.com, sboyd@codeaurora.org, maxime.ripard@free-electrons.com, s.hauer@pengutronix.de, geert@linux-m68k.org, "Lee Jones" References: <1453127331-20616-1-git-send-email-lee.jones@linaro.org> <1453127331-20616-3-git-send-email-lee.jones@linaro.org> Message-ID: <20160211004327.26445.27416@quark.deferred.io> User-Agent: alot/0.3.6 Subject: Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock Date: Wed, 10 Feb 2016 16:43:27 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lee Jones (2016-01-18 06:28:50) > Signed-off-by: Lee Jones Looks good to me. Regards, Mike > --- > drivers/clk/clk.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 835cb85..178b364 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -575,6 +575,9 @@ static void clk_core_unprepare(struct clk_core *core) > if (WARN_ON(core->prepare_count == 0)) > return; > > + if (WARN_ON(core->prepare_count == 1 && core->flags & CLK_IS_CRITICAL)) > + return; > + > if (--core->prepare_count > 0) > return; > > @@ -680,6 +683,9 @@ static void clk_core_disable(struct clk_core *core) > if (WARN_ON(core->enable_count == 0)) > return; > > + if (WARN_ON(core->enable_count == 1 && core->flags & CLK_IS_CRITICAL)) > + return; > + > if (--core->enable_count > 0) > return; > > -- > 1.9.1 >