From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbcBKMNN (ORCPT ); Thu, 11 Feb 2016 07:13:13 -0500 Received: from SMTP.ANDREW.CMU.EDU ([128.2.105.202]:42349 "EHLO smtp.andrew.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbcBKMNL (ORCPT ); Thu, 11 Feb 2016 07:13:11 -0500 Date: Thu, 11 Feb 2016 07:12:43 -0500 From: "Gabriel L. Somlo" To: Valentin Rothberg Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Andreas Ziegler Subject: Re: [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF Message-ID: <20160211121219.GA15680@GLSMBP.INI.CMU.EDU> References: <1455189170-42076-1-git-send-email-valentin.rothberg@posteo.net> <1455189543-42347-1-git-send-email-valentin.rothberg@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455189543-42347-1-git-send-email-valentin.rothberg@posteo.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.5.24 (2015-08-30) X-PMX-Version: 6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.2.11.115716 X-SMTP-Spam-Clean: 28% ( SXL_IP_DYNAMIC 3, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, FROM_EDU_TLD 0, NO_URI_HTTPS 0, RDNS_GENERIC_POOLED 0, RDNS_POOLED 0, RDNS_SUSP 0, RDNS_SUSP_GENERIC 0, RDNS_SUSP_SPECIFIC 0, REFERENCES 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __RDNS_POOLED_10 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0) X-SMTP-Spam-Score: 28% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 12:19:03PM +0100, Valentin Rothberg wrote: > s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/ Thanks for catching that ! Acked-by: Gabriel Somlo > > Signed-off-by: Valentin Rothberg > Signed-off-by: Andreas Ziegler > --- > v2: corrected typo in signed-off-by > > drivers/firmware/qemu_fw_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 19f6851be87f..fedbff55a7f3 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void) > } > > /* arch-specific ctrl & data register offsets are not available in ACPI, DT */ > -#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF)) > +#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF)) > # if (defined(CONFIG_ARM) || defined(CONFIG_ARM64)) > # define FW_CFG_CTRL_OFF 0x08 > # define FW_CFG_DATA_OFF 0x00 > -- > 2.5.0 >