From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbcBLAfR (ORCPT ); Thu, 11 Feb 2016 19:35:17 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47006 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbcBLAfO (ORCPT ); Thu, 11 Feb 2016 19:35:14 -0500 Date: Fri, 12 Feb 2016 00:35:02 +0000 From: Mark Brown To: Tejun Heo Cc: Paolo Valente , Jens Axboe , Fabio Checconi , Arianna Avanzini , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org Message-ID: <20160212003502.GD1953@sirena.org.uk> References: <1454364778-25179-1-git-send-email-paolo.valente@linaro.org> <1454364778-25179-10-git-send-email-paolo.valente@linaro.org> <20160211222210.GC3741@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yVhtmJPUSI46BTXb" Content-Disposition: inline In-Reply-To: <20160211222210.GC3741@mtj.duckdns.org> X-Cookie: Do not write below this line. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH RFC 09/22] block, cfq: replace CFQ with the BFQ-v0 I/O scheduler X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 11, 2016 at 05:22:10PM -0500, Tejun Heo wrote: > > +/** > > + * struct bfq_data - per device data structure. > > + * @queue: request queue for the managed device. > > + * @sched_data: root @bfq_sched_data for the device. > > + * @busy_queues: number of bfq_queues containing requests (including the > > + * queue in service, even if it is idling). > ... > I'm personally not a big fan of documenting struct fields this way. > It's too easy to get them out of sync. If it's something that gets included in a generated document then people will tell you pretty quickly if it gets out of sync these days, 0day notices and there's people sending fixes quite frequently. --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWvSi1AAoJECTWi3JdVIfQ8dMH/1rAdy5e6/YplkgDB/2Xmlml Bt4tj1fT03d40GJkpqHUCiEAespkfrOiSqTHL0pAsTFFja1ap4je7OEDtYZ9CL5+ qVi7JgaImXi+eJ2AqhUcuEJfG68GEKQrhKegiFe+1fkFwiUKtqLBns0Z5UWWv9yk NZfNvK7fRrOcUqpaD+qRu7fcXvj4NQjkhE5kRlcGmyLJmP7WuyZRzzCFME4PUe2G lbbKuLxKeVvZLUr52nqqiG/T+hXgXH53enjrkDQNGJbnaTG0oyMaBVa+0dBuTiry w2pfMU96RdG+nKXTHPXoQicMfRYqYqyOem5s7dcVNJeMdyxyaGDaYiaTlgk8vLw= =GTeb -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--