mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Brauner <christian.brauner@mailbox.org>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] let kernfs_name_locked & kernfs_name return size_t
Date: Thu, 11 Feb 2016 19:18:07 -0800	[thread overview]
Message-ID: <20160212031807.GC10157@kroah.com> (raw)
In-Reply-To: <1455131226-6836-1-git-send-email-christian.brauner@mailbox.org>

On Wed, Feb 10, 2016 at 08:07:05PM +0100, Christian Brauner wrote:
> Simple patch that changes the return value of kernfs_name_locked and kernfs_name
> to size_t which alignes these functions with kernfs_path_len which also returns
> size_t.
> 
> Patch was made against for-4.5 branch of Tejun's cgroup tree.  (As per Tejun's
> request, ccing gregkh@linuxfoundation.org and linux-kernel@vger.kernel.org.)
> 
> Changelog
>         20150210: - Change return type of kernfs_name in kernfs.h as well.
>                   - Build tested against Tejun's for-4.5 tree, 4.5-rc2 and
>                     mainline 4.5-rc3.
> 
> *Note*, the changes in kernfs.h change the dummy return value of the static
> inline definition of kernfs_name from -ENOSYS. I changed it to 0 analogous to
> kernfs_path_len. I don't know if this is considered a deal-breaker.

Please don't change that, that's a behavior change, not just a "cleanup
the return type" change.

thanks,

greg k-h

      parent reply	other threads:[~2016-02-12  3:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 19:07 Christian Brauner
2016-02-10 19:07 ` Christian Brauner
2016-02-12  3:18 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212031807.GC10157@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=christian.brauner@mailbox.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome