From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbcBLSaz (ORCPT ); Fri, 12 Feb 2016 13:30:55 -0500 Received: from mail.skyhub.de ([78.46.96.112]:40929 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbcBLSav (ORCPT ); Fri, 12 Feb 2016 13:30:51 -0500 Date: Fri, 12 Feb 2016 19:30:48 +0100 From: Borislav Petkov To: Paolo Bonzini Cc: Suravee Suthikulpanit , joro@8bytes.org, alex.williamson@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com Subject: Re: [PART1 RFC 6/9] svm: Add interrupt injection via AVIC Message-ID: <20160212183048.GG4099@pd.tnic> References: <1455285574-27892-1-git-send-email-suravee.suthikulpanit@amd.com> <1455285574-27892-7-git-send-email-suravee.suthikulpanit@amd.com> <20160212141650.GB4504@pd.tnic> <56BE0043.9050701@amd.com> <20160212171406.GF4099@pd.tnic> <56BE229D.6030206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56BE229D.6030206@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 07:21:17PM +0100, Paolo Bonzini wrote: > Hmm, currently things such as MSR_VM_HSAVE_PA are defined in msr-index.h. But that one is used in 3 files AFAICT. > It's okay for me to move them to kvm_host.h or similar, but they should > all be treated the same. Right now this means adding the doorbell MSR > to msr-index.h. Only if it is used in multiple files. The doorbell thing is used once in svm.c. We don't want to make msr-index.h an encyclopedia of any MSR ever defined :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.