From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbcBMK7p (ORCPT ); Sat, 13 Feb 2016 05:59:45 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48237 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbcBMK7o (ORCPT ); Sat, 13 Feb 2016 05:59:44 -0500 Date: Sat, 13 Feb 2016 05:59:40 -0500 (EST) Message-Id: <20160213.055940.1894427692019983187.davem@davemloft.net> To: labbott@fedoraproject.org Cc: asarwade@vmware.com, thellstrom@vmware.com, jhansen@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait From: David Miller In-Reply-To: <1454611845-5358-1-git-send-email-labbott@fedoraproject.org> References: <1454611845-5358-1-git-send-email-labbott@fedoraproject.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 13 Feb 2016 02:59:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laura Abbott Date: Thu, 4 Feb 2016 10:50:45 -0800 > We receoved a bug report from someone using vmware: ... > transport->stream_enqueue may call copy_to_user so it should > not be called inside a prepare_to_wait. Narrow the scope of > the prepare_to_wait to avoid the bad call. This also applies > to vsock_stream_recvmsg as well. > > Reported-by: Vinson Lee > Tested-by: Vinson Lee > Signed-off-by: Laura Abbott Applied.