From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbcBMOl7 (ORCPT ); Sat, 13 Feb 2016 09:41:59 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33141 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbcBMOl6 (ORCPT ); Sat, 13 Feb 2016 09:41:58 -0500 Date: Sat, 13 Feb 2016 20:11:53 +0530 From: Amitoj Kaur Chawla To: linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr Subject: [PATCH] goldfish: Return correct error code Message-ID: <20160213144153.GA19589@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value of devm_kzalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; @@ e = devm_kzalloc(...); if (e == NULL) { ... return - -1 + -ENOMEM ; } // The single call site does not perform any checks on the return value, hence no change is required at the call site. Signed-off-by: Amitoj Kaur Chawla --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index e7a29e2..f15e3c9 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -222,7 +222,7 @@ static int setup_access_params_addr(struct platform_device *pdev, aps = devm_kzalloc(&pdev->dev, sizeof(struct access_params), GFP_KERNEL); if (!aps) - return -1; + return -ENOMEM; /* FIXME */ paddr = __pa(aps); -- 1.9.1