From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbcBMUEv (ORCPT ); Sat, 13 Feb 2016 15:04:51 -0500 Received: from mail-db3on0092.outbound.protection.outlook.com ([157.55.234.92]:35616 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751228AbcBMUEs (ORCPT ); Sat, 13 Feb 2016 15:04:48 -0500 Authentication-Results: savoirfairelinux.com; dkim=none (message not signed) header.d=none;savoirfairelinux.com; dmarc=none action=none header.from=mellanox.com; Date: Sat, 13 Feb 2016 22:03:53 +0200 From: Ido Schimmel To: Vivien Didelot CC: , , , "David S. Miller" , Jiri Pirko , Scott Feldman , Nikolay Aleksandrov , Stephen Hemminger , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH RFC 1/3] net: bridge: log state when setting it Message-ID: <20160213200353.GA17193@colbert.idosch.org> References: <1455312860-24666-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1455312860-24666-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1455312860-24666-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [149.78.144.178] X-ClientProxiedBy: DB4PR01CA0061.eurprd01.prod.exchangelabs.com (10.242.152.51) To AM2PR05MB0979.eurprd05.prod.outlook.com (25.161.234.141) X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB0979;2:JFmfjG8QfqOEfFLQD9PZFFrGPCdO7jnKLrKtX3ClTveDca+nsWZpfenWPKaQGTzEpeie0AwS2mXHJcBcxtrTux+TiSaKbYziup/sdtZK/t2xKgdodo5Zbe+xqv2fRwgSbUmkMAZFijyE9IgY2B3j3w==;3:lUXu1hrNrkvDx+1We98RWtkL1Ht9aHejU1WaorXXWCBiKGNUAZzitOj3nehaPxe9B7qBEEHja+sg38E54AhLz5IXrYeJgAdX4fXsIMs6zSQHK/gRB8t9pwa3a/Gf4Lqy;25:QBaMebtmMRXbX3wmTQrVXavgGv58YKRUUjOt3Q0Jx86nFAPRqnEvqZ74xjrkxwtASn0ngqHWAHFl5w5je+aztC6JhrYcmWGtFJyg5rVeVv29pwprMD44rvqIXyjG+aGmktPzaGMil7VZ3EfBMBtK9U4UblysuvIuKvsgfV+Pon2pKEfRzOUblyX5DmgJk4XD0h9bHt2a+Hsu9n+B/v+/PidvSxAMEPTm2JGobo59HIN5adg8cYmx5qzqLnj3mO0lh3yFE7pF7Am3KM1faZOUIY+qJSnmcDEDFX3uU91T20W1qT/gmf+LS+lmTqX3r0WP X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR05MB0979; X-MS-Office365-Filtering-Correlation-Id: 16a77f44-b0d6-4ff2-1376-08d334b0eb72 X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB0979;20:/Py4jkriMbY1bs4iOs91waJ8wSrKWAymJduVMJsWINKsuIuzVeQhOR0TnyHZ19iQhNtE0LbKJ5Cpca9ZRyn+vAInTRrkp2B/Z5lxC4/3YRfzUfP0kbjmOpytjLPXV+MUUxFQBT9++7bZUmivyqtRS/qiPloiJlRn30flS/RjMU9BsJER1nCx4hiOMKZ5gEWFLm4fSPbTG1gITfVw2iTzg3TeTSlQO9IN3Jzd02GXAw1hzL5REZiXfHJfNsAUxJmoHrhA6tjQQcBo4zJ7zVw8MYknHrIBGkrDnwXY4Y59Sni2uaZqB7xsQ3pIdVLo1yqQKQymYIRLWwyqW04F9xbkHaGw669O5NPxpjgMPVa4iXoF5wzz8T+eqZEswPBEQ33CeCo6yyavNFxEVSAbyu8x7dL9eLIEoDQx7D6MRYgssdpBtIrCihfOMy4hyepP0sN2r5k5VKv+TSkSw+WkhweppisagRGtU8ovdjfx5HDY9aoutpl2phFjnKKfDjLPdPuG;4:PXZArpa7CnxxpgcPE71Q9TI2AccJ7XmP+bUbVUtce8Z/RAig3jCJdbRi2633ezy0U0Uq2kr372rdkO1JPeBZ288P9EtNQVsOD06hYLVnwVyOCrgZpb3rWZHXy4o5zV/mTwnT+Ze278X9wvjvt0uNeoj7EAP3RJpTvLYFaKfotc/ot9F/PeZTHm0v61ARWATTScF9Dn6X1dO8ADvWTXBtCpVTj3GCI+aYuvEnmRjKVIf5olWRfXBCjtrrNzZaVlXvMLlgpvEEWrlG+ujldtTC63A4eY0p4U1YVzFYMTiuWbms6NJ2d1V43CMKWhZOiA60mnP2R7kRmkxWTenBwirIcciy2qpfT9L6S3fejFwN+FRnCyEK43Rv2kvVHKHmzIdx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:AM2PR05MB0979;BCL:0;PCL:0;RULEID:;SRVR:AM2PR05MB0979; X-Forefront-PRVS: 08512C5403 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(24454002)(19580395003)(19580405001)(76506005)(40100003)(83506001)(42186005)(122386002)(46406003)(5004730100002)(86362001)(66066001)(87976001)(47776003)(97756001)(92566002)(2950100001)(77096005)(1076002)(6116002)(586003)(33656002)(4001350100001)(4326007)(5001960100002)(3846002)(50466002)(2906002)(50986999)(54356999)(76176999)(110136002)(189998001)(5008740100001)(1096002)(23726003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR05MB0979;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM2PR05MB0979;23:ofA0lkPYhfdlPxambfTmTzaG+uB5hOd7PTknN9uyb?= =?us-ascii?Q?5+JtHARm6U8qi1+NwV8uz2s7ZvmGSfdt1AkXp9ZKVGYEWVGL4xtFoBUZH4FB?= =?us-ascii?Q?eXjlXvqyqpngX6WnNoSqVvtcXNOlWVcig8cuwI6vGxPohSz4ZNNw1eYcU0Ma?= =?us-ascii?Q?4/tEiE6j61BFDXgRmMBYAuBOdHJk52lZeBlqmpGAo3NvvrfWGvrAsMwje+Nl?= =?us-ascii?Q?LFRBgu83y3P5yWtnzQYGVtgdlZtxcHL/yqSvflGuA7wsqCkCV8Aysvn6URkn?= =?us-ascii?Q?n7nZB8cc4Zvt46Yupv5x8oC2YlWOtZY6DfQQq/sX0HzgAOWmGyrv2xVAcj5o?= =?us-ascii?Q?vpbY5F6grK8xwNZGfE1ek5bjTvfi9dcDsk+CNaWI6n7Ws8uqcPGarYJR+mx3?= =?us-ascii?Q?UsIWcOJnpbBT8BDm6//+x19FYtK1GtKvGnQFhDJVSzMWwD116KrKXF6aVwNq?= =?us-ascii?Q?NbRHgkM258dOJZBZcVc0K/FwN55xQ7GM0IJEUdXURyq6vxmLQ/dkyvgyblf+?= =?us-ascii?Q?+442YdHjkBxDl0SHvbh0Ky8C+JCw5TG3aTY15aSzGrvqXiYGYCM8XL+3L2UU?= =?us-ascii?Q?CQnI73vAt2H1sVMN4qzVk6CHjlZC27Jz+65cHW3I6B+8UnIZN8NUOThO0kC+?= =?us-ascii?Q?9/m6Kks2i3r8f7iu+GIwCdDScMXwC/8KpiyNXhEx34N7qTsTJttwQ2uHsHxl?= =?us-ascii?Q?S2SUhuaPNGm4imgs1b4gT0C8o1D+fyoIHCzyRQYqgXLsQWoJeeM2BPYYI6J9?= =?us-ascii?Q?UP0JnYVig1vobWymy9DTpQWWHvFx6gKjM/kxWd/1QIhIYIeqpUYislajGPMJ?= =?us-ascii?Q?pVheTQy6X1WUkH32MWXRcie0fGEM3PfLw7dtrOczTtn/m4jaxybvAX+gNFeI?= =?us-ascii?Q?JP/9iwwNYY6mbEC8HSVYtIiQdbGfYWqvF0wkwJ8vEY+nZJ/HCkYUmI7W/paF?= =?us-ascii?Q?IeNJjtyGWMmZSCM9dK948WOKIWsLdizQkrpbQ+1Hs/msTYXBX0NZqvTIH0Ax?= =?us-ascii?Q?AAjN5Kbp1OsAMvyDKfHmZH1+RYgabmPnvtKNFbclhDAAfihEreHhTsEhqW8v?= =?us-ascii?Q?+vEIJY+kPJ4uQqh8z03rfsWhqqP?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB0979;5:izGqh1VsXWWixo6hhpdXqAE/5J8wZEsvmd096pSNULiP4SEQhPRYLgZ+OR+C4QntAbdpoVOLR9aynDpKC5yIV7z5KQv9/eSp0ZkJxqOdprqRi3YvqdM77k+P8sxPE7IxCNEFyMg4PyFKNUHALFO05A==;24:S6WD5Po7dyJHLmNeAtG6VR043ge4hm2bjaB0HEU0l3YdDpbTU5tXILcueVpj7x7H+G12GC+I6B9Fhz6c9H5i2bAVTHcx83Pk9wwVtFpO2DI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2016 20:04:45.4944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB0979 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.didelot@savoirfairelinux.com wrote: Hi Vivien, >Every call to br_set_state is followed by a call to br_log_state. >Directly call it within br_set_state instead. > >Signed-off-by: Vivien Didelot >--- Maybe I'm missing something, but there are other instances of this pattern throughout the code, so why not convert them as well? See br_set_port_state() for example. Thanks. > net/bridge/br_stp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c >index b3cca12..077afca 100644 >--- a/net/bridge/br_stp.c >+++ b/net/bridge/br_stp.c >@@ -52,6 +52,8 @@ void br_set_state(struct net_bridge_port *p, unsigned int state) > if (err && err != -EOPNOTSUPP) > br_warn(p->br, "error setting offload STP state on port %u(%s)\n", > (unsigned int) p->port_no, p->dev->name); >+ else >+ br_log_state(p); > } > > /* called under bridge lock */ >@@ -126,7 +128,6 @@ static void br_root_port_block(const struct net_bridge *br, > (unsigned int) p->port_no, p->dev->name); > > br_set_state(p, BR_STATE_LISTENING); >- br_log_state(p); > br_ifinfo_notify(RTM_NEWLINK, p); > > if (br->forward_delay > 0) >@@ -407,7 +408,6 @@ static void br_make_blocking(struct net_bridge_port *p) > br_topology_change_detection(p->br); > > br_set_state(p, BR_STATE_BLOCKING); >- br_log_state(p); > br_ifinfo_notify(RTM_NEWLINK, p); > > del_timer(&p->forward_delay_timer); >@@ -431,7 +431,6 @@ static void br_make_forwarding(struct net_bridge_port *p) > else > br_set_state(p, BR_STATE_LEARNING); > >- br_log_state(p); > br_ifinfo_notify(RTM_NEWLINK, p); > > if (br->forward_delay != 0) >-- >2.7.1 >