From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbcBNFWi (ORCPT ); Sun, 14 Feb 2016 00:22:38 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:35843 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbcBNFWf (ORCPT ); Sun, 14 Feb 2016 00:22:35 -0500 Date: Sun, 14 Feb 2016 10:52:28 +0530 From: Viresh Kumar To: Krzysztof Kozlowski Cc: Stephen Boyd , "Rafael J. Wysocki" , Nishanth Menon , linux-pm@vger.kernel.org, Linux Kernel Mailing List , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Lukasz Majewski , Krzysztof Kozlowski Subject: Re: [next] Odroid XU3 boot fail after cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Message-ID: <20160214052228.GA18226@vireshk-i7> References: <56C008F2.3080807@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C008F2.3080807@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-02-16, 13:56, Krzysztof Kozlowski wrote: > Hi all, > > Recently Odroid XU3 failed to boot on linux-next > on multi_v7 defconfig. exynos defconfig boots fine. > > Probably the "cpufreq: dt: Use dev_pm_opp_set_rate() to > switch frequency" is important here: > commit 78c3ba5df96c875b1668e1cd3ee0a69e62454f32 > Author: Viresh Kumar > Date: Tue Feb 9 10:30:46 2016 +0530 > > cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency > > OPP core supports frequency/voltage changes based on the target > frequency now, use that instead of open coding the same in cpufreq-dt > driver. > > Signed-off-by: Viresh Kumar > Reviewed-by: Stephen Boyd > Signed-off-by: Rafael J. Wysocki Can you please try the below untested patch please ? diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index d7cd4e265766..a97b333036c9 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -1156,9 +1156,15 @@ static int opp_parse_supplies(struct dev_pm_opp *opp, struct device *dev, return -EINVAL; } - opp->u_volt = microvolt[0]; - opp->u_volt_min = microvolt[1]; - opp->u_volt_max = microvolt[2]; + if (count == 1) { + opp->u_volt = microvolt[0]; + opp->u_volt_min = opp->u_volt; + opp->u_volt_max = opp->u_volt; + } else { + opp->u_volt = microvolt[0]; + opp->u_volt_min = microvolt[1]; + opp->u_volt_max = microvolt[2]; + } /* Search for "opp-microamp-" */ prop = NULL; -- viresh