From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev
Date: Sun, 14 Feb 2016 00:06:23 -0700 [thread overview]
Message-ID: <20160214070623.GE9551@obsidianresearch.com> (raw)
In-Reply-To: <56BF4E1F.2030208@linux.vnet.ibm.com>
On Sat, Feb 13, 2016 at 10:39:11AM -0500, Stefan Berger wrote:
> >@@ -347,8 +347,8 @@ static int i2c_nuvoton_recv(struct tpm_chip *chip, u8 *buf, size_t count)
> > */
> > static int i2c_nuvoton_send(struct tpm_chip *chip, u8 *buf, size_t len)
> > {
> >- struct device *dev = chip->pdev;
> >- struct i2c_client *client = to_i2c_client(dev);
> >+ struct device *dev = &chip->dev;
> This looks wrong or are you fixing a bug here? chip->dev.parent ?
No, in this function dev is only used for dev_err/etc so it should be
changed, like every other dev_err/etc call in this patch.
Expect for this use:
> >+ struct i2c_client *client = to_i2c_client(chip->dev.parent);
>
> Does this need to be replaced ?
Which must stay as the parent.
Jason
next prev parent reply other threads:[~2016-02-14 7:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 0:04 [PATCH 0/3] Various struct device cleanups Jason Gunthorpe
2016-02-13 0:04 ` [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe
2016-02-13 10:08 ` Jarkko Sakkinen
2016-02-13 15:45 ` Jason Gunthorpe
2016-02-14 4:55 ` Jarkko Sakkinen
2016-02-14 6:50 ` Jason Gunthorpe
2016-02-14 8:02 ` Jarkko Sakkinen
2016-02-13 0:04 ` [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe
[not found] ` <201602130037.u1D0bDEN029756@d01av04.pok.ibm.com>
2016-02-13 1:11 ` Jason Gunthorpe
[not found] ` <201602130128.u1D1S2Xn006955@d01av05.pok.ibm.com>
2016-02-13 2:00 ` Jason Gunthorpe
2016-02-13 3:33 ` Jason Gunthorpe
2016-02-14 5:24 ` Jarkko Sakkinen
2016-02-14 6:57 ` Jason Gunthorpe
2016-02-14 8:03 ` Jarkko Sakkinen
2016-02-13 15:39 ` [tpmdd-devel] " Stefan Berger
2016-02-14 7:06 ` Jason Gunthorpe [this message]
2016-02-14 5:13 ` Jarkko Sakkinen
2016-02-13 0:04 ` [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe
2016-02-13 1:01 ` kbuild test robot
2016-02-13 1:13 ` Jason Gunthorpe
2016-02-14 5:16 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214070623.GE9551@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®