From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbcBOGhN (ORCPT ); Mon, 15 Feb 2016 01:37:13 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:54894 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbcBOGhJ (ORCPT ); Mon, 15 Feb 2016 01:37:09 -0500 X-AuditID: cbfee690-f79646d000001316-01-56c172136567 Date: Mon, 15 Feb 2016 15:37:07 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Liam Girdwood , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Mark Brown Subject: Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Message-id: <20160215063707.GC10719@samsunx.samsung> References: <1455250463-5955-1-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1455250463-5955-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWyRsSkWFe46GCYQcN7JYupD5+wWbx5u4bJ 4vULQ4tvVzqYLC7vmsNmMeP8PiYHNo+ds+6ye2xa1cnmsaUfyOrbsorR4/MmuQDWKC6blNSc zLLUIn27BK6MZafvMxZ0sFWc/HqQrYHxC0sXIyeHhICJRMuXZ8wQtpjEhXvr2UBsIYEVjBKN n5Nhan5fWgYU5wKKz2KUWNX9lx2i6COjxIqP6iA2i4CqxNOdE1hBbDYBTYmm2z/ABokImEr8 WvuCFaSZWWAPo8StCd/BioQF/CSWfWgAG8QLtGHp9CZGiKGuEv83XoaKC0r8mHwP7FJmAS2J 9TuPM0HY0hKP/s4Aq+EUcJOY/XIi0AccHKICKhKvDtaD7JIQOMYucXLXAWaI4wQkvk0+xAJS IyEgK7HpANTDkhIHV9xgmcAoNgvJtllIts1Csm0BI/MqRtHUguSC4qT0IhO94sTc4tK8dL3k /NxNjMBIO/3v2YQdjPcOWB9iFOBgVOLhjThzIEyINbGsuDL3EKMp0BUTmaVEk/OB8ZxXEm9o bGZkYWpiamxkbmmmJM77WupnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQbG0qc9sjULti9d 8Vv/aMTFvZsNHLwkZRbUfee56LsxoeKl/5T1eun6p937/zpqM+e4b578YebMihkK4WcNCx+e DhCbvvmb7WrRx4aq97/0dZzfomuRsrY1W8+cRzBc/m/kmXr+UsEHuwqPVEm6WjxumaqybXct 56LDDzgda61OloY2nDfn73VWYinOSDTUYi4qTgQA7729la8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsVy+t9jQV3hooNhBr8myVlMffiEzeLN2zVM Fq9fGFp8u9LBZHF51xw2ixnn9zE5sHnsnHWX3WPTqk42jy39QFbfllWMHp83yQWwRjUw2mSk JqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAXaCkUJaYUwoU CkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzFh2+j5jQQdbxcmvB9kaGL+wdDFyckgI mEj8vrSMDcIWk7hwbz2QzcUhJDCLUWJV9192kISQwEdGiRUf1UFsFgFViac7J7CC2GwCmhJN t3+ANYsImEr8WvuCFaSZWWAPo8StCd/BioQF/CSWfWgAG8QLtG3p9CZGiKGuEv83XoaKC0r8 mHwP7CJmAS2J9TuPM0HY0hKP/s4Aq+EUcJOY/XIicxcjB4eogIrEq4P1ExiBrkTonoWkexaS 7gWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxguP5mfQOxsO73A8xCnAwKvHwRpw5 ECbEmlhWXJl7iFGCg1lJhNcv/WCYEG9KYmVValF+fFFpTmrxIUZTYIBMZJYSTc4Hppq8knhD YxMzI0sjc0MLI2NzJXHex//XhQkJpCeWpGanphakFsH0MXFwSjUwRi3b+uemdlu+63ajLYuY leuDj7XoerFeyxD68uB98WrXax3OhuE/cvPqjbTOf8wsik/UnNzsnnVrdc8bceWA7bM6fvBN W3615fKeeXO+v1t+UPRfQsf3rzu+mTKaPZ7EfF3Kd8vHrSL2Oj3brEN+hXd4zvqxMICR4837 iif6x1MCxNS/ny9uUGIpzkg01GIuKk4EAOWT2Mf9AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 01:14:23AM -0300, Javier Martinez Canillas wrote: > The max77686 and max77802 regulator drivers are for sub-devices of a MFD > driver for some PMIC blocks. But the same object file name (max77686.o) > was used for both the common MFD driver and the max77686 regulator one. > > This confuses kbuild if both drivers are built as module causing the MFD > driver to not be copied when installing the modules. > > Also, max77{686,802} are a quite generic name for MFD subdevices drivers > so it is better to rename them to max77{686,802}-regulator like it's the > case for most regulator drivers. > > Signed-off-by: Javier Martinez Canillas Looks good. Reviewed-by: Andi Shyti Andi