From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbcBOI3Z (ORCPT ); Mon, 15 Feb 2016 03:29:25 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:32869 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbcBOI3V (ORCPT ); Mon, 15 Feb 2016 03:29:21 -0500 Date: Mon, 15 Feb 2016 13:59:13 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List , Juri Lelli Subject: Re: [PATCH 3/9] cpufreq: governor: Fix nice contribution computation in dbs_check_cpu() Message-ID: <20160215082913.GI6334@vireshk-i7> References: <3329748.lhJgppdTt9@vostro.rjw.lan> <4591302.DXuxEtjCGY@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4591302.DXuxEtjCGY@vostro.rjw.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-02-16, 02:15, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The contribution of the CPU nice time to the idle time in dbs_check_cpu() > is computed in a bogus way, as the code may subtract current and previous > nice values for different CPUs. > > That doesn't matter for cases when cpufreq policies are not shared, > but may lead to problems otherwise. > > Fix the computation and simplify it to avoid taking unnecessary steps. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq_governor.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) Acked-by: Viresh Kumar -- viresh