From: Mark Brown <broonie@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] spi: rockchip: add debug interface support
Date: Mon, 15 Feb 2016 17:26:32 +0000 [thread overview]
Message-ID: <20160215172632.GQ18988@sirena.org.uk> (raw)
In-Reply-To: <1455524902-2780-1-git-send-email-shawn.lin@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Mon, Feb 15, 2016 at 04:28:22PM +0800, Shawn Lin wrote:
> +#ifdef CONFIG_DEBUG_FS
> +#include <linux/debugfs.h>
> +#endif
Just include the header. Only add ifdefs if they do something.
> +static int rockchip_spi_debugfs_init(struct rockchip_spi *rs)
> +{
> + rs->debugfs = debugfs_create_dir("rockchip_spi", NULL);
> + if (!rs->debugfs)
> + return -ENOMEM;
> +
> + debugfs_create_file("regs", S_IFREG | S_IRUGO,
> + rs->debugfs, (void *)rs, &rockchip_spi_dbg_ops);
> + return 0;
> +}
This is completely separate to the core debugfs support for SPI, if
we're adding new debugfs stuff that's per device we should be extending
the core debugfs stuff so everything is in one place.
Your register dump stuff looks like you might want to consider using
regmap, it's got this and other register access diagnostics already.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-15 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:27 [PATCH 0/3] Some rockchip_spi fixes and debug support Shawn Lin
2016-02-15 8:27 ` [PATCH 1/3] spi: rockchip: disable runtime pm when in err case Shawn Lin
2016-02-15 8:28 ` [PATCH 2/3] spi: rockchip: add missing spi_master_put Shawn Lin
2016-02-15 8:28 ` [PATCH 3/3] spi: rockchip: add debug interface support Shawn Lin
2016-02-15 17:26 ` Mark Brown [this message]
2016-02-16 1:32 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215172632.GQ18988@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®