From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754624AbcBPJRN (ORCPT ); Tue, 16 Feb 2016 04:17:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:50008 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513AbcBPJRJ (ORCPT ); Tue, 16 Feb 2016 04:17:09 -0500 Date: Tue, 16 Feb 2016 10:17:06 +0100 From: Johannes Thumshirn To: Sudip Mukherjee Cc: Adaptec OEM Raid Solutions , "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] [SCSI] dpt_i2o: fix build warning Message-ID: <20160216091706.GH18134@c203.arch.suse.de> References: <1455611856-7009-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455611856-7009-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 02:07:36PM +0530, Sudip Mukherjee wrote: > We were getting build warning about: > drivers/scsi/dpt_i2o.c:183:29: warning: ‘dptids’ defined but not used > > dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not > defined then dptids[] becomes unused. Nah. Care to make a proper pci driver from it instead of plastering yet another #ifdef in? > > Signed-off-by: Sudip Mukherjee > --- > drivers/scsi/dpt_i2o.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c > index d4cda5e..21c8d21 100644 > --- a/drivers/scsi/dpt_i2o.c > +++ b/drivers/scsi/dpt_i2o.c > @@ -180,11 +180,14 @@ static u8 adpt_read_blink_led(adpt_hba* host) > *============================================================================ > */ > > +#ifdef MODULE > static struct pci_device_id dptids[] = { > { PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,}, > { PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,}, > { 0, } > }; > +#endif > + > MODULE_DEVICE_TABLE(pci,dptids); > > static int adpt_detect(struct scsi_host_template* sht) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850