From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754971AbcBPL2T (ORCPT ); Tue, 16 Feb 2016 06:28:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36357 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754546AbcBPL2R (ORCPT ); Tue, 16 Feb 2016 06:28:17 -0500 Date: Tue, 16 Feb 2016 12:28:14 +0100 From: Jiri Olsa To: Ingo Molnar Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 0/5] perf tools: Store CPU cache details under perf data Message-ID: <20160216112814.GA24086@krava.brq.redhat.com> References: <1455465826-8426-1-git-send-email-jolsa@kernel.org> <20160216081413.GA31489@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160216081413.GA31489@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 09:14:13AM +0100, Ingo Molnar wrote: > > * Jiri Olsa wrote: > > > hi, > > adding support to store CPU cache details under perf data. > > > > $ perf report --header-only -I > > ... > > # cache info: > > # L1 Data 32K [0-1] > > # L1 Instruction 32K [0-1] > > # L1 Data 32K [2-3] > > # L1 Instruction 32K [2-3] > > # L2 Unified 256K [0-1] > > # L2 Unified 256K [2-3] > > # L3 Unified 4096K [0-3] > > Very small UI nit, wouldn't it be nicer if this displayed tabular output, and if > numbers were adjusted to their decimal point, i.e. something like: > > > # CPU cache info: > > # L1 Data 32K [0-1] > > # L1 Instruction 32K [0-1] > > # L1 Data 32K [2-3] > > # L1 Instruction 32K [2-3] > > # L2 Unified 256K [0-1] > > # L2 Unified 256K [2-3] > > # L3 Unified 4096K [0-3] > > (Also note that it says 'CPU cache info' - there are a lot of caches in the > system.) yep, looks better.. will change thanks, jirka