From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbcBPMj1 (ORCPT ); Tue, 16 Feb 2016 07:39:27 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53878 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755063AbcBPMjY (ORCPT ); Tue, 16 Feb 2016 07:39:24 -0500 Date: Tue, 16 Feb 2016 12:38:54 +0000 From: Mark Brown To: Vignesh R Cc: Tony Lindgren , Brian Norris , Rob Herring , Russell King , "hramrach@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" Message-ID: <20160216123854.GJ18327@sirena.org.uk> References: <1449807000-6457-1-git-send-email-vigneshr@ti.com> <1449807000-6457-4-git-send-email-vigneshr@ti.com> <20160209193616.GN13270@sirena.org.uk> <56BC1D3E.5020203@ti.com> <20160212223711.GD18988@sirena.org.uk> <56C2D731.6050306@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HSQ3hISbU3Um6hch" Content-Disposition: inline In-Reply-To: <56C2D731.6050306@ti.com> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 92.40.248.175 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HSQ3hISbU3Um6hch Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 16, 2016 at 01:30:49PM +0530, Vignesh R wrote: > On 02/13/2016 04:07 AM, Mark Brown wrote: > > On Thu, Feb 11, 2016 at 11:03:50AM +0530, Vignesh R wrote: > >> On 02/10/2016 01:06 AM, Mark Brown wrote: > >>> Looking at this I can't help but think that spi_flash_read() ought to > >>> have the stub in rather than the caller. But given that we're pretty > >>> much only ever expecting one user I'm not 100% sure it actually matters. > >> Well, my initial patch set passed long list of arguments to > >> spi_flash_read(), but Brian suggested to use struct[1] in order to avoid > >> unnecessary churn when things need changed in the API. > > I don't see what that has to do with my point? > AFAIU, your previous comment was to move initialization of > spi_flash_read_message struct to spi_flash_read(). This would mean No, not at all. I'm talking about how we handle the case where we don't have hardware support for this and need to implement it in software - currently that's in a separate place to the place where we call the driver. --HSQ3hISbU3Um6hch Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWwxhUAAoJECTWi3JdVIfQVM0H/j64x3bLpAv0cTZC+2n0VAOm 5oSygJJOfQqjzFBhmpPdJfd1BvVzJnSb7Lh42eGLlehbABTwyHc5upivQNti/D5H FYwmZDhCge7Ewj0YDB9Q2StXsUKw1X0QMFFlRXMZlB06TkBIKYMfp04jorAs9ZdI osCAbMdjt/bZ9EqMxEcR+Mief5y1BYEVZS3ridmPtBazefEhNBkQ43yvwXNIPdkw yRxBFlDLteJO1E1+bUbumGFj8cb1jC2DvuG6PjuQUJ14g+gZ+f02FHQ5XH+uuAGu 0RPS4Jqm6YM0Nv00H8rRj8PWYglqqLwUcHT4gNcW6vOtgu/6AX04dcVuak0zY2w= =m7oA -----END PGP SIGNATURE----- --HSQ3hISbU3Um6hch--