From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964802AbcBPQOj (ORCPT ); Tue, 16 Feb 2016 11:14:39 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:53544 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932339AbcBPQOf (ORCPT ); Tue, 16 Feb 2016 11:14:35 -0500 Date: Tue, 16 Feb 2016 16:12:56 +0000 From: One Thousand Gnomes To: Andy Shevchenko Cc: Vladimir Murzin , Arnd Bergmann , Russell King , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Mark Rutland , Pawel Moll , "ijc+devicetree" , Kumar Gala , Jiri Slaby , Rob Herring , devicetree , "linux-serial@vger.kernel.org" , "linux-api@vger.kernel.org" , linux-arm Mailing List , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Message-ID: <20160216161256.234a2be8@lxorguk.ukuu.org.uk> In-Reply-To: References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-6-git-send-email-vladimir.murzin@arm.com> <56C31F9F.10000@arm.com> <56C32641.4020201@arm.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > If you do insist to have a counter I'll add one, but if you are not > > strong about it I'd prefer to leave it as is. > > I would wait for Peter Hurley, Alan, or other experienced guys to talk. I would leave it. Some of the drivers have defensive code of this form, but mostly because they can be hot unplugged and we don't want to spin into oblivion because the user ejected a serial card adapter. Alan