From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbcBPTwE (ORCPT ); Tue, 16 Feb 2016 14:52:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33661 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbcBPTwC (ORCPT ); Tue, 16 Feb 2016 14:52:02 -0500 Date: Tue, 16 Feb 2016 14:51:58 -0500 From: Jessica Yu To: Miroslav Benes Cc: Jiri Kosina , Josh Poimboeuf , Rusty Russell , Seth Jennings , Vojtech Pavlik , Petr Mladek , Steven Rostedt , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch/module: remove livepatch module notifier Message-ID: <20160216195157.GA7538@packer-debian-8-amd64.digitalocean.com> References: <1454993424-31031-1-git-send-email-jeyu@redhat.com> <1454993424-31031-5-git-send-email-jeyu@redhat.com> <87r3glzbzj.fsf@rustcorp.com.au> <20160215232735.GC3018@treble.redhat.com> <20160216004809.GA29917@packer-debian-8-amd64.digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Miroslav Benes [16/02/16 09:41 +0100]: >On Mon, 15 Feb 2016, Jessica Yu wrote: > >> +++ Jiri Kosina [16/02/16 00:42 +0100]: >> > On Mon, 15 Feb 2016, Josh Poimboeuf wrote: >> > >> > > So I think the commit causing the regression is 5156dca34a3e, which >> > > occurred in the 4.5 cycle, *not* in 4.4. >> > >> > Agreed, by "4.4 regresion" I mean "regression compared to 4.4"; i.e. >> > regression that will become real issue once 4.5 is released. >> > >> > > Also it's my understanding that only the third patch ("remove ftrace >> > > module notifier") is needed to fix the regression, and the other patches >> > > are just general improvements. So if needed I think we can just rebase >> > > that patch (which already has Rusty's ack I believe) and send it to >> > > Linus now. >> > >> > 3/4 and 4/4 are be sufficient, yes (although I'd like to have this >> > confimed by Jessica, as she apparently already has a reliable testcase). >> >> Yes, so Josh is right; technically only patch 3/4 "ftrace/module: >> remove ftrace module notifier" is sufficient enough to fix the bug, >> and patch 4/4 is just a natural extension of that change. Since I'm >> going to be sending out another patchset anyway without the module.c >> cleanups, I'll just keep them together. > >Yes, 3/4 should be sufficient to fix the bug. However if you take 4/4 too, >you need 1/4 as well. Otherwise we would introduce a bug in error handling >as Petr pointed out. > Hm. I am just realizing that patch 4/4 will still need new ACK's for the error handling portion. What I'll do is, after testing, send out patch 3/4 ("ftrace/module: remove ftrace module notifier") as a standalone patch to be merged immediately, since it fixes an actual bug. The rest of this patchset will follow separately and can be reviewed at its own pace. Jessica