From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752428AbcBQFMa (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 00:12:30 -0500
Received: from mail-pf0-f169.google.com ([209.85.192.169]:36685 "EHLO
	mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750740AbcBQFM3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 00:12:29 -0500
Date: Wed, 17 Feb 2016 10:42:18 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly
Message-ID: <20160217051218.GI2454@vireshk-i7>
References: <76641630.CimCW8476L@vostro.rjw.lan>
 <4864381.Sc603abrG6@vostro.rjw.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4864381.Sc603abrG6@vostro.rjw.lan>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16-02-16, 21:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Drop some lines of code from od_update() by arranging the statements
> in there in a more logical way.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_ondemand.c |   11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -175,14 +175,11 @@ static void od_update(struct cpufreq_pol
>  		/* No longer fully busy, reset rate_mult */
>  		policy_dbs->rate_mult = 1;
>  
> -		if (!od_tuners->powersave_bias) {
> -			__cpufreq_driver_target(policy, freq_next,
> -					CPUFREQ_RELATION_C);
> -			return;
> -		}
> +		if (od_tuners->powersave_bias)
> +			freq_next = od_ops.powersave_bias_target(policy,
> +								 freq_next,
> +								 CPUFREQ_RELATION_L);
>  
> -		freq_next = od_ops.powersave_bias_target(policy, freq_next,
> -					CPUFREQ_RELATION_L);
>  		__cpufreq_driver_target(policy, freq_next, CPUFREQ_RELATION_C);
>  	}
>  }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh