From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161244AbcBQLCQ (ORCPT ); Wed, 17 Feb 2016 06:02:16 -0500 Received: from mga02.intel.com ([134.134.136.20]:56197 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161131AbcBQLCN (ORCPT ); Wed, 17 Feb 2016 06:02:13 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,459,1449561600"; d="scan'208";a="886857970" Date: Wed, 17 Feb 2016 19:04:41 +0800 From: kbuild test robot To: Anand Jain Cc: kbuild-all@01.org, David Sterba , "Chris Mason Chris Mason" , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: fix ifnullfree.cocci warnings Message-ID: <20160217110441.GA21406@lkp-sb04> References: <201602171939.Xe24Ni6m%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201602171939.Xe24Ni6m%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Anand Jain Signed-off-by: Fengguang Wu --- volumes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1882,8 +1882,7 @@ int btrfs_rm_device(struct btrfs_root *r } out: - if (dev_name) - kfree(dev_name); + kfree(dev_name); mutex_unlock(&uuid_mutex); return ret;