From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Jyri Sarha <jsarha@ti.com>,
linux-clk@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kristo, Tero" <t-kristo@ti.com>
Subject: Re: [PATCH 4/4] ASoC: simple-card: Support for selecting system clocks by ID
Date: Wed, 17 Feb 2016 12:07:59 +0000 [thread overview]
Message-ID: <20160217120759.GO7544@sirena.org.uk> (raw)
In-Reply-To: <56C42BAF.3050900@ti.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Wed, Feb 17, 2016 at 10:13:35AM +0200, Peter Ujfalusi wrote:
> With this change we don't need to write custom machine drivers for setup not
> using sysclk_id == 0.
> I do think this is reasonable change by itself.
> However I do think that the current simple-card is flawed regarding to clock
> selection and the change Jyri and me are proposing is reasonable.
But you define a new ABI to specify it in the process, I'd rather fix
the flaws by using the common clock ABI than extend any device stuff.
If it didn't define a new ABI I'd probably not worry about it but one of
the issues we have with DT is that we do end up making ABIs every time
we put something in DT.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-17 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1455545495-20292-1-git-send-email-peter.ujfalusi@ti.com>
[not found] ` <1455545495-20292-5-git-send-email-peter.ujfalusi@ti.com>
[not found] ` <20160215152635.GN18988@sirena.org.uk>
2016-02-16 9:46 ` Peter Ujfalusi
2016-02-16 13:42 ` Mark Brown
2016-02-16 19:13 ` Michael Turquette
2016-02-17 8:13 ` Peter Ujfalusi
2016-02-17 12:07 ` Mark Brown [this message]
2016-02-17 19:52 ` Peter Ujfalusi
2016-04-18 15:50 ` [alsa-devel] " Peter Ujfalusi
2016-04-18 16:29 ` Mark Brown
2016-04-21 22:29 ` Stephen Boyd
2016-04-22 11:52 ` Peter Ujfalusi
2016-04-22 12:08 ` Tero Kristo
2016-02-17 11:31 ` Mark Brown
2016-02-17 14:18 ` [alsa-devel] " Ricard Wanderlof
2016-02-22 3:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217120759.GO7544@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@ti.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®