From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161612AbcBQNTT (ORCPT ); Wed, 17 Feb 2016 08:19:19 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37636 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161335AbcBQNTR (ORCPT ); Wed, 17 Feb 2016 08:19:17 -0500 Date: Wed, 17 Feb 2016 14:19:43 +0100 From: Daniel Vetter To: Amitoj Kaur Chawla Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] drm/udl: Use module_usb_driver Message-ID: <20160217131943.GG32705@phenom.ffwll.local> Mail-Followup-To: Amitoj Kaur Chawla , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr References: <20160217121327.GA29682@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217121327.GA29682@amitoj-Inspiron-3542> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 05:43:27PM +0530, Amitoj Kaur Chawla wrote: > Macro module_usb_driver is used for drivers whose init and exit paths > only register and unregister to usb API. So remove boilerplate code to > make code simpler by using module_usb_driver. > > This change was made with the help of the following Coccinelle > semantic patch: > > // > @a@ > identifier f, x; > @@ > -static f(...) { return usb_register(&x); } > > @b depends on a@ > identifier e, a.x; > @@ > -static e(...) { usb_deregister(&x); } > > @c depends on a && b@ > identifier a.f; > declarer name module_init; > @@ > -module_init(f); > > @d depends on a && b && c@ > identifier b.e, a.x; > declarer name module_exit; > declarer name module_usb_driver; > @@ > -module_exit(e); > +module_usb_driver(x); > // > > Signed-off-by: Amitoj Kaur Chawla Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/udl/udl_drv.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c > index d5728ec..772ec9e 100644 > --- a/drivers/gpu/drm/udl/udl_drv.c > +++ b/drivers/gpu/drm/udl/udl_drv.c > @@ -125,17 +125,5 @@ static struct usb_driver udl_driver = { > .disconnect = udl_usb_disconnect, > .id_table = id_table, > }; > - > -static int __init udl_init(void) > -{ > - return usb_register(&udl_driver); > -} > - > -static void __exit udl_exit(void) > -{ > - usb_deregister(&udl_driver); > -} > - > -module_init(udl_init); > -module_exit(udl_exit); > +module_usb_driver(udl_driver); > MODULE_LICENSE("GPL"); > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch