mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
	Intel graphics driver community testing & development 
	<intel-gfx@lists.freedesktop.org>,
	Linux kernel development <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] [RFC] kernel/cpu: Use lockref for online CPU reference counting
Date: Wed, 17 Feb 2016 15:20:05 +0100	[thread overview]
Message-ID: <20160217142005.GD6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1455713251.5622.9.camel@linux.intel.com>

On Wed, Feb 17, 2016 at 02:47:31PM +0200, Joonas Lahtinen wrote:
> On ti, 2016-02-16 at 12:07 +0100, Peter Zijlstra wrote:
> > On Tue, Feb 16, 2016 at 12:51:03PM +0200, Joonas Lahtinen wrote:
> > > Quoting my original patch;
> > > 
> > > "See the Bugzilla link for more details.
> > 
> > If its not in the Changelog it doesn't exist. Patches should be self
> > contained and not refer to external sources for critical information.
> 
> The exact locking case in CPUfreq drivers causing a splat is described
> in the patch. Details were already included, that's why term "more
> details" was used.

Barely. What was not described was why you went to tinker with the
hotplug lock instead of sanitizing cpufreq. Nor why your chosen solution
is good.

> This is not exactly taking us closer to a fix, 

Why you think we can discuss fixes if you've not actually described your
problem is beyond me.

  reply	other threads:[~2016-02-17 14:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 12:36 Joonas Lahtinen
2016-02-15 14:17 ` Peter Zijlstra
2016-02-15 17:06   ` Peter Zijlstra
2016-02-16  8:49     ` Joonas Lahtinen
2016-02-16  9:14       ` Peter Zijlstra
2016-02-16 10:51         ` Joonas Lahtinen
2016-02-16 11:07           ` Peter Zijlstra
2016-02-17 12:47             ` Joonas Lahtinen
2016-02-17 14:20               ` Peter Zijlstra [this message]
2016-02-17 16:13                 ` Daniel Vetter
2016-02-17 16:14                   ` Peter Zijlstra
2016-02-17 16:33                     ` [Intel-gfx] " Daniel Vetter
2016-02-17 16:37                       ` Peter Zijlstra
2016-02-18 10:39                         ` Joonas Lahtinen
2016-02-18 10:54     ` Joonas Lahtinen
2016-02-15 17:18   ` [Intel-gfx] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217142005.GD6357@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=daniel@ffwll.ch \
    --cc=ego@linux.vnet.ibm.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome