From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423544AbcBQOjo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 09:39:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46191 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964898AbcBQOjn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 09:39:43 -0500
Date: Wed, 17 Feb 2016 15:39:38 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/23] perf record: Add --all-user/--all-kernel options
Message-ID: <20160217143938.GA23265@krava.brq.redhat.com>
References: <1455525293-8671-1-git-send-email-jolsa@kernel.org>
 <1455525293-8671-2-git-send-email-jolsa@kernel.org>
 <20160216165601.GF17690@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160216165601.GF17690@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 16, 2016 at 01:56:01PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 15, 2016 at 09:34:31AM +0100, Jiri Olsa escreveu:
> > Allow user to easily switch all events to user or
> > kernel space with simple --all-user or --all-kernel
> > options.
> > 
> > This will be handy within perf mem/c2c wrappers to
> > switch easily monitoring modes.
> 
> Humm, some oddities:
> 
>   # perf record --all-user -e cycles -a
>   # perf report --tui       # And then notice there are some kernel samples, zoom into kernel DSO
>   Samples: 7  of event 'cycles', Event count (approx.): 3158810, DSO: [kernel.vmlinux]
>   Overhead  Comman  Symbol
>     84.05%  chrome  [k] page_fault
>     15.73%  chrome  [k] entry_SYSCALL_64
>      0.22%  chrome  [k] apic_timer_interrupt
> 
> Ditto when using --all-kernel, some userspace samples are there, also perhaps we
> should show "cycles:u" or "cycles:k" when this --all-user or --all-kernel features
> are used.
> 
> Need to investigate why there are kernel samples when --all-user is used and
> the other way around as well.
> 
> Also if I use both it quietly accepts and shows just one of them, I guess we
> should bail out in case someone tries both.

right, that should be handled with warning and exit
I'll do it in next version

thanks,
jirka