From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423098AbcBQUgk (ORCPT ); Wed, 17 Feb 2016 15:36:40 -0500 Received: from smtprelay0233.hostedemail.com ([216.40.44.233]:34184 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964970AbcBQUgi (ORCPT ); Wed, 17 Feb 2016 15:36:38 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2731:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:5007:6261:7875:8660:10004:10400:10848:10967:11026:11232:11658:11914:12050:12438:12517:12519:12663:12740:13069:13148:13230:13311:13357:14096:14097:14659:21080:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:18,LUA_SUMMARY:none X-HE-Tag: money70_3968080741b1a X-Filterd-Recvd-Size: 2781 Date: Wed, 17 Feb 2016 15:36:33 -0500 From: Steven Rostedt To: Jiri Kosina Cc: Jessica Yu , Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , Miroslav Benes , Petr Mladek , Rusty Russell , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ftrace/module: remove ftrace module notifier Message-ID: <20160217153633.231ea651@gandalf.local.home> In-Reply-To: References: <1455661953-15838-1-git-send-email-jeyu@redhat.com> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Feb 2016 21:35:29 +0100 (CET) Jiri Kosina wrote: > On Tue, 16 Feb 2016, Jessica Yu wrote: > > > Remove the ftrace module notifier in favor of directly calling > > ftrace_module_enable() and ftrace_release_mod() in the module loader. > > Hard-coding the function calls directly in the module loader removes > > dependence on the module notifier call chain and provides better > > visibility and control over what gets called when, which is important > > to kernel utilities such as livepatch. > > > > This fixes a notifier ordering issue in which the ftrace module notifier > > (and hence ftrace_module_enable()) for coming modules was being called > > after klp_module_notify(), which caused livepatch modules to initialize > > incorrectly. This patch removes dependence on the module notifier call > > chain in favor of hard coding the corresponding function calls in the > > module loader. This ensures that ftrace and livepatch code get called in > > the correct order on patch module load and unload. > > > > Fixes: 5156dca34a3e ("ftrace: Fix the race between ftrace and insmod") > > Signed-off-by: Jessica Yu > > Reviewed-by: Steven Rostedt > > Steven, I am going to assume that your Reviewed-by: still holds for the > patch even though it has been removed from the 4-patch series; if you > don't agree, please speak up. Otherwise, I am going to apply it and push > it to Linus for -rc5 still (as it fixes our regression). > This week has been very busy. Did the patch change at all? -- Steve