From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423355AbcBQSmb (ORCPT ); Wed, 17 Feb 2016 13:42:31 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:35674 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422929AbcBQSmT (ORCPT ); Wed, 17 Feb 2016 13:42:19 -0500 Date: Wed, 17 Feb 2016 18:41:26 +0000 From: One Thousand Gnomes To: Amitoj Kaur Chawla Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] goldfish: Return proper error code Message-ID: <20160217184126.59c0ae36@lxorguk.ukuu.org.uk> In-Reply-To: <20160217172329.GA9026@amitoj-Inspiron-3542> References: <20160217172329.GA9026@amitoj-Inspiron-3542> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Feb 2016 22:53:29 +0530 Amitoj Kaur Chawla wrote: > This change has been made with the goal that kernel functions should > return something more descriptive than -1 on failure. > > Change the return value on valid_batchbuffer_addr() failure from -1 > to -EINVAL. > > Signed-off-by: Amitoj Kaur Chawla NAK. It's not user visible, it's a piece of code that has a pile of other more important fixes needed first, and it's also as far as possible kept aligned with the Android upstream. If it were some random otherwise unchanging bit of code then it might just about make sense but in this case no - especially when you only change one of the two returns of -1 ! Alan