From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161855AbcBQTLB (ORCPT ); Wed, 17 Feb 2016 14:11:01 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43303 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030411AbcBQTLA (ORCPT ); Wed, 17 Feb 2016 14:11:00 -0500 Date: Wed, 17 Feb 2016 11:10:59 -0800 From: Greg Kroah-Hartman To: Victor Dodon Cc: linux-kernel@vger.kernel.org, Matthew Dharm , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, Gwendal Grignou Subject: Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US_DEBUGPX Message-ID: <20160217191059.GA27066@kroah.com> References: <20160217184237.GA125188@printesoi1.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217184237.GA125188@printesoi1.mtv.corp.google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote: > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead. > > Signed-off-by: Victor Dodon > -- > Changes in v2: > - Completely remove the macro instead of using printk_emit > - Change all uses of US_DEBUGPX to usb_stor_dbg Great! Now can you get rid of the horrid USB_DEBUG() macro as well? I don't think that's really needed anymore (the frecom driver's usage can just be removed entirely). thanks, greg k-h