From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946812AbcBRQKL (ORCPT ); Thu, 18 Feb 2016 11:10:11 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:43408 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946578AbcBRQKJ (ORCPT ); Thu, 18 Feb 2016 11:10:09 -0500 Date: Thu, 18 Feb 2016 11:10:07 -0500 (EST) Message-Id: <20160218.111007.1949710047777164403.davem@davemloft.net> To: amsfield22@gmail.com Cc: mac@melware.de, isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps From: David Miller In-Reply-To: <1455777311-3190-1-git-send-email-amsfield22@gmail.com> References: <20151120182307.GA3513@d830.WORKGROUP> <1455777311-3190-1-git-send-email-amsfield22@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Feb 2016 08:10:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alison Schofield Date: Wed, 17 Feb 2016 22:35:11 -0800 > divamnt stores a start_time at module init and uses it to calculate > elapsed time. The elapsed time, stored in secs and usecs, is part of > the trace data the driver maintains for the DIVA Server ISDN cards. > No change to the format of that time data is required. > > To avoid overflow on 32-bit systems use ktime_get_ts64() to return > the elapsed monotonic time since system boot. > > This is a change from real to monotonic time. Since the driver only > stores elapsed time, monotonic time is sufficient and more robust > against real time clock changes. These new monotonic values can be > more useful for debugging because they can be easily compared to > other monotonic timestamps. > > Note elaspsed time values will now start at system boot time rather > than module load time, so they will differ slightly from previously > reported values. > > Remove declaration and init of previously unused time constants: > start_sec, start_usec. > > Signed-off-by: Alison Schofield > Reviewed-by: Arnd Bergmann Applied to net-next, thanks.