From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947664AbcBRT7D (ORCPT ); Thu, 18 Feb 2016 14:59:03 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46348 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946104AbcBRT7B (ORCPT ); Thu, 18 Feb 2016 14:59:01 -0500 Date: Thu, 18 Feb 2016 14:58:59 -0500 (EST) Message-Id: <20160218.145859.1842263482402756546.davem@davemloft.net> To: amitoj1606@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH v2] lance: Return correct error code From: David Miller In-Reply-To: <20160217150326.GA3116@amitoj-Inspiron-3542> References: <20160217150326.GA3116@amitoj-Inspiron-3542> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Feb 2016 11:59:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amitoj Kaur Chawla Date: Wed, 17 Feb 2016 20:33:26 +0530 > Failure of kzalloc should cause the enclosing function > to return -ENOMEM, not -ENODEV. > > Additionally, removed the following checkpatch warnings: > ERROR: spaces required around that '==' (ctx:VxV) > ERROR: space required before the open parenthesis '(' > CHECK: Comparison to NULL could be written "!lp" > > Signed-off-by: Amitoj Kaur Chawla Applied, thanks.