From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948255AbcBRVAP (ORCPT ); Thu, 18 Feb 2016 16:00:15 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47368 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948008AbcBRVAN (ORCPT ); Thu, 18 Feb 2016 16:00:13 -0500 Date: Thu, 18 Feb 2016 16:00:09 -0500 (EST) Message-Id: <20160218.160009.1485326686227753180.davem@davemloft.net> To: arnd@arndb.de Cc: oliver@neukum.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: cdc_subset: only build when one driver is enabled From: David Miller In-Reply-To: <1455747932-2844084-1-git-send-email-arnd@arndb.de> References: <1455747932-2844084-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Feb 2016 13:00:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 17 Feb 2016 23:25:11 +0100 > This avoids a harmless randconfig warning I get when USB_NET_CDC_SUBSET > is enabled, but all of the more specific drivers are not: > > drivers/net/usb/cdc_subset.c:241:2: #warning You need to configure some hardware for this driver > > The current behavior is clearly intentional, giving a warning when > a user picks a configuration that won't do anything good. The only > reason for even addressing this is that I'm getting close to > eliminating all 'randconfig' warnings on ARM, and this came up > a couple of times. > > My workaround is to not even build the module when none of the > configurations are enable. > > Alternatively we could simply remove the #warning (nothing wrong > for compile-testing), turn it into a runtime warning, or > change the Kconfig options into a menu to hide CONFIG_USB_NET_CDC_SUBSET. > > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.