From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424360AbcBRBhO (ORCPT ); Wed, 17 Feb 2016 20:37:14 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:53065 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424157AbcBRBhI (ORCPT ); Wed, 17 Feb 2016 20:37:08 -0500 X-AuditID: cbfee691-f79766d0000012b6-5f-56c52042c9b5 Date: Thu, 18 Feb 2016 10:37:06 +0900 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jacob.e.keller@intel.com, Arnd Bergmann Subject: Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON Message-id: <20160218013705.GI10719@samsunx.samsung> References: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWyRsSkUNdJ4WiYwcfzkhZ/Jx1jt5j68Amb xYljC1ksXr8wtPh2pYPJ4vKuOWwWM87vY7K4uOILkwOHx+9fkxg9ds66y+6xeM9LJo9NqzrZ PPq2rGL0+LxJLoAtissmJTUnsyy1SN8ugSvj+Y4ZTAX72CvurTnH3sDYy9bFyMkhIWAi8fDK dFYIW0ziwr31QHEuDiGBFYwSj6/vYYUpmr56MQuILSQwi1HiTq8PRNFHRomlO2YDFXFwsAio Slz/Hw5SwyagKdF0+wfYAhEBQ4mDu7czgdQzC7xhlPj37ys7SEJYIExi7sLpYEW8QAuWP5vP CLHAXeL++3OMEHFBiR+T74EtZhbQkli/8zgThC0t8ejvDHaQvZwCHhKz30uAmKICKhKvDtaD rJIQuMcuMXvvObBWFgEBiW+TD7GA1EgIyEpsOsAM8ZakxMEVN1gmMIrNQrJsFpJls5AsW8DI vIpRNLUguaA4Kb3IVK84Mbe4NC9dLzk/dxMjMApP/3s2cQfj/QPWhxgFOBiVeHg5Xh8JE2JN LCuuzD3EaAp0xURmKdHkfGCs55XEGxqbGVmYmpgaG5lbmimJ8+pI/wwWEkhPLEnNTk0tSC2K LyrNSS0+xMjEwSnVwGgksvTmDF8jpWUtDxo053qfmr9w7fIXP6y6f2w0ki7hLRO0F7QQszwq OcN6YVjQTQcDlk+XQsqXnJn/gjlpruOZ5emlH5hY9ypVl7DNvmClekA9O8XHTqrYaha35qGf E/ep3/rtdH9NvGnHGY2HNY+incK7gxNNmBQamLZM2rny2dQDf3ia25RYijMSDbWYi4oTAZJZ LOG9AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsVy+t9jQV0nhaNhBot7RSz+TjrGbjH14RM2 ixPHFrJYvH5haPHtSgeTxeVdc9gsZpzfx2RxccUXJgcOj9+/JjF67Jx1l91j8Z6XTB6bVnWy efRtWcXo8XmTXABbVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqt kotPgK5bZg7QQUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjOc7ZjAV 7GOvuLfmHHsDYy9bFyMnh4SAicT01YtZIGwxiQv31oPFhQRmMUrc6fXpYuQCsj8ySizdMZu1 i5GDg0VAVeL6/3CQGjYBTYmm2z/A6kUEDCUO7t7OBFLPLPCGUeLfv6/sIAlhgTCJuQungxXx Ai1b/mw+I8QCd4n7788xQsQFJX5Mvgd2BLOAlsT6nceZIGxpiUd/Z7CD7OUU8JCY/V4CxBQV UJF4dbB+AiPQjQjNs5A0z0LSvICReRWjRGpBckFxUnquYV5quV5xYm5xaV66XnJ+7iZGcKQ/ k9rBeHCX+yFGAQ5GJR5ejtdHwoRYE8uKK3MPMUpwMCuJ8PryHQ0T4k1JrKxKLcqPLyrNSS0+ xGgKDI6JzFKiyfnAJJRXEm9obGJmZGlkbmhhZGyuJM77+P+6MCGB9MSS1OzU1ILUIpg+Jg5O qQZG4dP7Z6rcva32SuC+vWxFO/eTsxYHOXeEeM8N6JDa/ou5eUK45znVdsODTVa9hw99uRsr WuzAE8knwyliOiOx+UtV/+NbLObrJmfIzTffJx3+n2WxwcvjKn/XiHY4blb7fbq0cm91qNq9 z18zqtJzFt5SPhbwaO7ObVeb9l63nbREPDOj90iwEktxRqKhFnNRcSIA9gyIVwoDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, > Following BUILD_BUG_ON using a variable fails for some of the compilers > and optimization levels (reported for gcc 4.9): > var = ARRAY_SIZE(s2mps15_regulators); > BUILD_BUG_ON(S2MPS_REGULATOR_MAX < var); > Fix this by using ARRAY_SIZE directly. > > Additionally add missing BUILD_BUG_ON check for S2MPS15 device (the > check ensures that internal arrays are big enough to hold data for all > of regulators on all devices). > > Reported-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > [...] > case S2MPS11X: > s2mps11->rdev_num = ARRAY_SIZE(s2mps11_regulators); Why don't we remove rdev_num at all? It's not used that much other than in the probe function. > regulators = s2mps11_regulators; > - BUILD_BUG_ON(S2MPS_REGULATOR_MAX < s2mps11->rdev_num); > + BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mps11_regulators)); > break; Andi