From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424377AbcBRBqY (ORCPT ); Wed, 17 Feb 2016 20:46:24 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:53452 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422771AbcBRBqW (ORCPT ); Wed, 17 Feb 2016 20:46:22 -0500 X-AuditID: cbfee68d-f79646d000001355-7c-56c5226264d0 Date: Thu, 18 Feb 2016 10:46:10 +0900 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jacob.e.keller@intel.com, Arnd Bergmann Subject: Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON Message-id: <20160218014610.GJ10719@samsunx.samsung> References: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> <20160218013705.GI10719@samsunx.samsung> <56C520A7.40201@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <56C520A7.40201@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRsSkSDdJ6WiYwcIGLYu/k46xW0x9+ITN 4sSxhSwWr18YWny70sFkcXnXHDaLGef3MVlcXPGFyYHD4/evSYweO2fdZfdYvOclk8emVZ1s Hn1bVjF6fN4kF8AWxWWTkpqTWZZapG+XwJVx4Pt9xoJDHBU7p81laWB8zNbFyMkhIWAicbK1 kwnCFpO4cG89WFxIYAWjxNzNDjA1Gx/9BIpzAcWXMkqsen0QyvnIKPFj5mpGkCoWAVWJ95On s4PYbAKaEk23f4BNEhEwlDi4ezsTSAOzwBtGiX//voIVCQuEScxdOB2siBdoRdf56awQq/sZ JXa8SoWIC0r8mHyPBcRmFtCSWL/zOBOELS3x6O8MoDkcHJxAy6Y99AMxRQVUJF4drAdZJSFw i13i2OUFbBC3CUh8m3yIBaRGQkBWYtMBZojHJCUOrrjBMoFRbBaSZbOQLJuFZNkCRuZVjKKp BckFxUnpRYZ6xYm5xaV56XrJ+bmbGIFxePrfs94djLcPWB9iFOBgVOLh5Xh9JEyINbGsuDL3 EKMp0BUTmaVEk/OB0Z5XEm9obGZkYWpiamxkbmmmJM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1 +BAjEwenVAOjemlGwZkPF2+EVWQE2fD15UcLrvSWjbwYG6dV9Nz2ZGBEbfYGnYOcbr9nc4vd fNNl6pVyubDut1S4wlIfR7HZB2513YlnmX01MWVTu4+6sH55oeR5nfd1r4SqFJ6In5ecXHGJ XYF9vuo1vnX3n+x6oyvFX/HxUZObTMupy18F1k37Ia/YKqLEUpyRaKjFXFScCADQt89IvgIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t9jAd0kpaNhBneOqFj8nXSM3WLqwyds FieOLWSxeP3C0OLblQ4mi8u75rBZzDi/j8ni4oovTA4cHr9/TWL02DnrLrvH4j0vmTw2repk 8+jbsorR4/MmuQC2qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRb JRefAF23zBygg5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGQe+32cs OMRRsXPaXJYGxsdsXYycHBICJhIbH/2EssUkLtxbD2RzcQgJLGWUWPX6IJTzkVHix8zVjCBV LAKqEu8nT2cHsdkENCWabv8A6xYRMJQ4uHs7E0gDs8AbRol//76CFQkLhEnMXTgdrIgXaF3X +emsILaQQD+jxI5XqRBxQYkfk++xgNjMAloS63ceZ4KwpSUe/Z0BNIeDgxNo2bSHfiCmqICK xKuD9RMYBWYhaZ6FpHkWkuYFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYKj/Zn0 DsbDu9wPMQpwMCrx8HK8PhImxJpYVlyZe4hRgoNZSYTXl+9omBBvSmJlVWpRfnxRaU5q8SFG U2B4TGSWEk3OByaivJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1 MHLPz/hjfeb/lCd/fbl3nptsmHTzVqvHvYJ2988XytJ8kgyn3N1q3NX+0/yF0Ay2H0zB2+VM Lphcnan0UqdOKvDtvMMdyywlzPjjvf5u+CEiM9ErdG290lS7o5tPdEu9/DE7ZMKbO8EuYiJz EhryS8T4cyRD49ezJ1Rq7zQVethmHF3WY7JwjRJLcUaioRZzUXEiAD7m5X4MAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> Following BUILD_BUG_ON using a variable fails for some of the compilers > >> and optimization levels (reported for gcc 4.9): > >> var = ARRAY_SIZE(s2mps15_regulators); > >> BUILD_BUG_ON(S2MPS_REGULATOR_MAX < var); > >> Fix this by using ARRAY_SIZE directly. > >> > >> Additionally add missing BUILD_BUG_ON check for S2MPS15 device (the > >> check ensures that internal arrays are big enough to hold data for all > >> of regulators on all devices). > >> > >> Reported-by: Arnd Bergmann > >> Signed-off-by: Krzysztof Kozlowski > >> > > > > [...] > > > >> case S2MPS11X: > >> s2mps11->rdev_num = ARRAY_SIZE(s2mps11_regulators); > > > > Why don't we remove rdev_num at all? It's not used that much > > other than in the probe function. > > Remove from probe? It is used in probe and removal would make the code > more complicated than it should be. no, I mean remove it from s2mps11_info. Other than in the probe this value is used only once in s2mps11_pmic_dt_parse() (which is called by probe()). Andi