From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425054AbcBRFej (ORCPT ); Thu, 18 Feb 2016 00:34:39 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:55237 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424699AbcBRFeh (ORCPT ); Thu, 18 Feb 2016 00:34:37 -0500 Date: Wed, 17 Feb 2016 21:34:34 -0800 From: Darren Hart To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Oleksandr Natalenko , corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Message-ID: <20160218053434.GF18421@dvhart-mobl5.amr.corp.intel.com> References: <4f2df9dab959ad572e08eb7f7fa03220@natalenko.name> <20160217103738.GA1609@tyrael> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160217103738.GA1609@tyrael> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 12:37:38PM +0200, Giedrius Statkevičius wrote: > On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote: > > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module > > is loaded with wapf=4 option. Add quirk for this. > > --- > > You forgot Signed-off-by here. Always run your patch through > scripts/checkpatch.pl. Also, I think the format is usually > [PATCH RESEND vX AA/BB] and not [PATCH][RESEND]. RESEND means it's identical. v2 means there was a change. The change should be noted below the --- line. See Documentation/SubmittingPatches Section 14. -- Darren Hart Intel Open Source Technology Center