From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424017AbcBRGJu (ORCPT ); Thu, 18 Feb 2016 01:09:50 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34784 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756923AbcBRGJs (ORCPT ); Thu, 18 Feb 2016 01:09:48 -0500 Date: Thu, 18 Feb 2016 11:39:35 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List Subject: Re: [PATCH 11/12] cpufreq: governor: Make dbs_data_mutex static Message-ID: <20160218060935.GQ2610@vireshk-i7> References: <2938006.67J0esUvOA@vostro.rjw.lan> <1655404.H6dIaK3J3n@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1655404.H6dIaK3J3n@vostro.rjw.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-02-16, 02:33, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > That mutex is only used by cpufreq_governor_dbs() and it doesn't > need to be exported to modules, so make it static and drop the > export incantation. > > No functional changes. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq_governor.c | 3 +-- > drivers/cpufreq/cpufreq_governor.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > Index: linux-pm/drivers/cpufreq/cpufreq_governor.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.c > +++ linux-pm/drivers/cpufreq/cpufreq_governor.c > @@ -24,8 +24,7 @@ > > static DEFINE_PER_CPU(struct cpu_dbs_info, cpu_dbs); > > -DEFINE_MUTEX(dbs_data_mutex); > -EXPORT_SYMBOL_GPL(dbs_data_mutex); > +static DEFINE_MUTEX(dbs_data_mutex); > > /* Common sysfs tunables */ > /** > Index: linux-pm/drivers/cpufreq/cpufreq_governor.h > =================================================================== > --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.h > +++ linux-pm/drivers/cpufreq/cpufreq_governor.h > @@ -178,7 +178,6 @@ struct od_ops { > unsigned int freq_next, unsigned int relation); > }; > > -extern struct mutex dbs_data_mutex; > unsigned int dbs_update(struct cpufreq_policy *policy); > int cpufreq_governor_dbs(struct cpufreq_policy *policy, unsigned int event); > void od_register_powersave_bias_handler(unsigned int (*f) Acked-by: Viresh Kumar -- viresh