From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425282AbcBRIM7 (ORCPT ); Thu, 18 Feb 2016 03:12:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33497 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965431AbcBRIM5 (ORCPT ); Thu, 18 Feb 2016 03:12:57 -0500 Date: Thu, 18 Feb 2016 09:12:53 +0100 From: Benjamin Tissoires To: =?utf-8?B?PT9VVEYtOD9xP0NsPUMzPUE5bWVudD0yMFZ1Y2hlbmVyPz0=?= Cc: Jiri Kosina , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] HID: corsair: fix mapping of non-keyboard usages Message-ID: <20160218081253.GL8577@mail.corp.redhat.com> References: <20160216173824.GA23019@untxi.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160216173824.GA23019@untxi.home> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 16 2016 or thereabouts, =?UTF-8?q?Cl=C3=A9ment=20Vuchener?= wrote: > This fixes a bug where the Volume Up key was ignored because it uses the same usage code as G18. Special Corsair usage codes are in the keyboard page, other pages should be left to the generic driver. > > Signed-off-by: Clément Vuchener Looks good to me. Reviewed-by: Benjamin Tissoires Cheers, Benjamin > --- > drivers/hid/hid-corsair.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c > index 5855196..717704e 100644 > --- a/drivers/hid/hid-corsair.c > +++ b/drivers/hid/hid-corsair.c > @@ -595,6 +595,9 @@ static int corsair_input_mapping(struct hid_device *dev, > { > int gkey; > > + if ((usage->hid & HID_USAGE_PAGE) != HID_UP_KEYBOARD) > + return 0; > + > gkey = corsair_usage_to_gkey(usage->hid & HID_USAGE); > if (gkey != 0) { > hid_map_usage_clear(input, usage, bit, max, EV_KEY, > -- > 2.5.0 >