From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946107AbcBRO3b (ORCPT ); Thu, 18 Feb 2016 09:29:31 -0500 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:34642 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425404AbcBRO33 (ORCPT ); Thu, 18 Feb 2016 09:29:29 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3280:3354:3622:3865:3866:3867:3870:3871:3874:4321:4385:4470:5007:6261:6742:7514:7875:8784:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12555:12740:13255:13891:14096:14097:14659:21080:30012:30029:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: title25_6fb25943f6a17 X-Filterd-Recvd-Size: 3915 Date: Thu, 18 Feb 2016 09:29:26 -0500 From: Steven Rostedt To: js1304@gmail.com Cc: Andrew Morton , Michal Nazarewicz , Minchan Kim , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation Message-ID: <20160218092926.083ca007@gandalf.local.home> In-Reply-To: <1455505490-12376-2-git-send-email-iamjoonsoo.kim@lge.com> References: <1455505490-12376-1-git-send-email-iamjoonsoo.kim@lge.com> <1455505490-12376-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Feb 2016 12:04:50 +0900 js1304@gmail.com wrote: > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index 534249c..fd6d9a5 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -1,6 +1,54 @@ > #include > #include > #include > +#include > + > +extern struct tracepoint __tracepoint_page_ref_set; > +extern struct tracepoint __tracepoint_page_ref_mod; > +extern struct tracepoint __tracepoint_page_ref_mod_and_test; > +extern struct tracepoint __tracepoint_page_ref_mod_and_return; > +extern struct tracepoint __tracepoint_page_ref_mod_unless; > +extern struct tracepoint __tracepoint_page_ref_freeze; > +extern struct tracepoint __tracepoint_page_ref_unfreeze; > + > +#ifdef CONFIG_DEBUG_PAGE_REF Please add a comment here. Something to the effect of: /* * Ideally we would want to use the trace__enabled() helper * functions. But due to include header file issues, that is not * feasible. Instead we have to open code the static key functions. * * See trace_##name##_enabled(void) in include/linux/tracepoint.h */ I may have to work on something that lets these helpers be defined in headers. I have some ideas on how to do that. But for now, this solution is fine. -- Steve > +#define page_ref_tracepoint_active(t) static_key_false(&(t).key) > + > +extern void __page_ref_set(struct page *page, int v); > +extern void __page_ref_mod(struct page *page, int v); > +extern void __page_ref_mod_and_test(struct page *page, int v, int ret); > +extern void __page_ref_mod_and_return(struct page *page, int v, int ret); > +extern void __page_ref_mod_unless(struct page *page, int v, int u); > +extern void __page_ref_freeze(struct page *page, int v, int ret); > +extern void __page_ref_unfreeze(struct page *page, int v); > + > +#else > + > +#define page_ref_tracepoint_active(t) false > + > +static inline void __page_ref_set(struct page *page, int v) > +{ > +} > +static inline void __page_ref_mod(struct page *page, int v) > +{ > +} > +static inline void __page_ref_mod_and_test(struct page *page, int v, int ret) > +{ > +} > +static inline void __page_ref_mod_and_return(struct page *page, int v, int ret) > +{ > +} > +static inline void __page_ref_mod_unless(struct page *page, int v, int u) > +{ > +} > +static inline void __page_ref_freeze(struct page *page, int v, int ret) > +{ > +} > +static inline void __page_ref_unfreeze(struct page *page, int v) > +{ > +} > + > +#endif > >