From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965645AbcBRMNh (ORCPT ); Thu, 18 Feb 2016 07:13:37 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38447 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965496AbcBRMNf (ORCPT ); Thu, 18 Feb 2016 07:13:35 -0500 Date: Thu, 18 Feb 2016 13:13:33 +0100 From: Michal Hocko To: Tetsuo Handa Cc: rientjes@google.com, akpm@linux-foundation.org, mgorman@suse.de, oleg@redhat.com, torvalds@linux-foundation.org, hughd@google.com, andrea@kernel.org, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm,oom: exclude oom_task_origin processes if they are OOM-unkillable. Message-ID: <20160218121333.GD18149@dhcp22.suse.cz> References: <1455719460-7690-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20160218080909.GA18149@dhcp22.suse.cz> <201602181930.HIH09321.SFVFOQLHOFMJOt@I-love.SAKURA.ne.jp> <20160218120849.GC18149@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218120849.GC18149@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 18-02-16 13:08:49, Michal Hocko wrote: > I guess we can safely remove the memcg > argument from oom_badness and oom_unkillable_task. At least from a quick > glance... No we cannot actually. oom_kill_process could select a child which is in a different memcg in that case... -- Michal Hocko SUSE Labs