From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947944AbcBRUfZ (ORCPT ); Thu, 18 Feb 2016 15:35:25 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:47538 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424609AbcBRUfX (ORCPT ); Thu, 18 Feb 2016 15:35:23 -0500 Date: Thu, 18 Feb 2016 21:35:16 +0100 From: Francois Romieu To: Chunhao Lin Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Message-ID: <20160218203516.GA18173@electric-eye.fr.zoreil.com> References: <1455807427-3177-1-git-send-email-hau@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455807427-3177-1-git-send-email-hau@realtek.com> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chunhao Lin : [...] > I add checking driver's pm runtime status in rtl8169_get_stats64() to fix > this issue. Would you consider taking the device out of suspended mode during rtl8169_get_stats64 to prevent outdated stats ? -- Ueimor