From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992694AbcBSCny (ORCPT ); Thu, 18 Feb 2016 21:43:54 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38839 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948133AbcBSCnw (ORCPT ); Thu, 18 Feb 2016 21:43:52 -0500 Date: Thu, 18 Feb 2016 18:43:50 -0800 From: Stephen Boyd To: Matthew McClintock Cc: Matthew McClintock , Andy Gross , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, qca-upstream.external@qca.qualcomm.com, Senthilkumar N L , Varadarajan Narayanan Subject: Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board Message-ID: <20160219024350.GQ4847@codeaurora.org> References: <1447975173-29485-1-git-send-email-mmcclint@qca.qualcomm.com> <1447975173-29485-6-git-send-email-mmcclint@qca.qualcomm.com> <20160208224328.GB10791@codeaurora.org> <59152C1B-683F-417D-9C23-C6E3F53D7096@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59152C1B-683F-417D-9C23-C6E3F53D7096@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16, Matthew McClintock wrote: > On Feb 8, 2016, at 4:43 PM, Stephen Boyd wrote: > > > > On 11/19, Matthew McClintock wrote: > >> + > >> +/ { > >> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1"; > >> + compatible = "qcom,ipq4019"; > >> + > >> + clocks { > >> + xo: xo { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <48000000>; > >> + #clock-cells = <0>; > >> + }; > >> + }; > > > > Is there a reason the xo is here and the sleep clk is in the SoC > > dtsi file? Both are board clocks so I would think they would be > > added in the same place. > > I’m a little bit confused and I wanted to confirm. I can see the xo clock is on the board itself. However, the sleep_clk is not, can you clarify why they would both be in the same place? > The sleep clk is typically a pin on the SoC package. Look at your schematic. Same goes for the XO. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project